search

xbmc-imx6 / xbmc

XBMC Main Repository
http://xbmc.org
Other
32 stars 5 forks source link

h.264 constrained baseline #101

Open rabeeh opened 9 years ago

rabeeh commented 9 years ago

While running 24fps / 23.796fps motion bar test kodi defaults to ffmpeg because of this line -

https://github.com/xbmc/xbmc/blob/master/xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecIMX.cpp#L426

I'v removed the (m_hints.profile == 578) that forbids the content to be decoded by vpu and it worked without issues.

Any idea why this constrained is there?

The test content is downloaded from here - http://st7.us/MotionBarsH264.7z

wolfgar commented 9 years ago

Hi Rabeeh

Thanks a lot for your report, To give you the context of this removal, @fritsch submitted a sample that was not properly played https://stephan-rafin.net/owncloud/public.php?service=files&t=899902a115819476001f91221525935d At that time, I had a look at the sample properties and only the profile value seemed quite uncommon so I though the issue was with it and I opened the following PR : https://github.com/xbmc/xbmc/pull/5964 Given your report, it is clear that my conclusion was too fast and it is not about the profile itself... So I will open a new PR upstream (dev is no longer done in this repo) to remove the filtering but we have to understand what is wrong with the other sample...

fritsch commented 9 years ago

I will also look into it after @rabeeh posted the kernel patch we are missing in the other thread :-)

rabeeh commented 9 years ago

just tried it again on OE 5.0.2 with constrained baseline enabled to be decoded by vpu; still fails -

08:00:53 T:1555031104 ERROR: Decode - VPU decode failed with error code 1. 08:00:53 T:1555031104 DEBUG: CDVDPlayerVideo - video decoder returned error