Closed sraue closed 10 years ago
wolfgar
commented
10 years ago Thanks a lot I will merge StringUtils::Split stuff tomorrow (I am in the process of reviewing/cleaning code for PR)
For audio in fact we are about to get rid of this stuff : see https://github.com/xbmc-imx6/xbmc/issues/68#issuecomment-51150477 and #62 and #14 ...
koying
commented
10 years ago Yep. To avoid XBMC patches due to IMX bugs, we went the asound.rc way. I tested a build (not OE) with just the master-pr + asound.rc and works fine for me
warped-rudi
commented
10 years ago @koying, I don't think this is a IMX bug. It's normal ALSA behavior. However, I would not suggest to put the configuration in asound.rc. This is, because this file is intended for per-user audio tweaks. Since this is something that is required in all cases, I'd vote for /usr/share/alsa/cards/ . BTW, I'm thinking if it would be good to create the surroundXX devices as well. Or at least a 'front' device that maps to the analog codec...
koying
commented
10 years ago My knowledge of ALSA is very limited, but it is somewhat my assumption that if imx6 behave "normally", we wouldn't need #ifdef's ;)
Anyway, asound.rc is just an example. I meant that XBMC will most probably not accept those alsa hackings and that it has to be fixed outside, in an ALSA config file or another. Obviously, OE/Geexbox implement it the way they see fit.
wolfgar
commented
10 years ago In fact I had pushed similar change on the 19th of june : https://github.com/xbmc-imx6/xbmc/commit/63f99cd6951d938928a48eed410c1819fb5cb54d and I though Chris grabbed my branch when we had to resolve the merge of 24bits... I close this PR as I have cherry picked the change
This PR fixes a build issue after https://github.com/xbmc-imx6/xbmc/commit/74f3f02 and adds HDMI audio support (found in master-pr before the last rebase, added ifdef's for imx)