search

xbmc / Kore

Kore is a simple and easy-to-use Kodi remote.
Apache License 2.0
649 stars 243 forks source link

revert "Flip RTL text before sending it #184" #1024

Closed amiremohamadi closed 2 weeks ago

amiremohamadi commented 3 weeks ago

seems like it's been fixed in kodi while ago and we should not reverse the input string anymore. @SyncedSynapse

basilgello commented 3 weeks ago

If minimal version of Kodi that Kore supports has the original issue fixed, then simply removing the code is enough. Otherwise, you need to guard that with a flag that is set once on connection estabilishment.

amiremohamadi commented 3 weeks ago

@basilgello reversing the text has never been a correct solution. imagine a situation in which our text is a mixture of RTL and LTR words. therefore, I believe it's a correct behavior not to handle it on the Kore.

basilgello commented 3 weeks ago

OK, just checking as I was not aware of the problem (and its "fix")

SyncedSynapse commented 3 weeks ago

No idea about what the correct behaviour should be. @amiremohamadi Do you have a link to the Kodi PR that fixed the issue? @royiarchy Do you have any input into this.

If the issue was fixed in a specific version of Kodi, what basilgello was referring to was keeping the code, but guarding it with something like 

if (! hostManager.getHostInfo().isLeiaOrLater) {
    // Removed code to reverse text
}

Not sure if necessary

amiremohamadi commented 3 weeks ago

@SyncedSynapse I guess it's solved in this commit. IMO keeping the previous code (reversing the whole text) for the older versions is unnecessary as it will still mess up mixed RTL/LTR texts (even in the older versions of kodi).