search

xbmc / Kore

Kore is a simple and easy-to-use Kodi remote.
Apache License 2.0
647 stars 245 forks source link

Add support for the Invidious YouTube add-on #979

Closed wtimme closed 11 months ago

wtimme commented 1 year ago

Introduction

This branch adds basic support for the Invidious YouTube add-on, as proposed in #978.

The only thing that is working so far is the direct playback of shared video URLs, which - as mentioned in the original issue - is an MVP that could be extended upon.

This new feature is lacking translation. If I can help with that as well let me know.

How to test

  1. Checkout the branch and run the app in the emulator
  2. Connect the app to a Kodi instance
  3. Install NewPipe
  4. Open NewPipe, select a video and share the video with Kore

Kodi should display a brief loading indicator and then playback the video.

Thanks in advance for your time and consideration!

SyncedSynapse commented 11 months ago

Ok, i'm not 100% sure about this.

My issue is that there's no modular way for specifying plugins in Kore, so each plugin that is supported is being tightly coupled in Kore's code, and that's not something that i find scalable. Up until now, plugins dealt with different providers (arte.tv, svtplay, etc), so that was transparent to the user, but this requires a new option in the settings, getting very visible to the user, and it can get unwieldy soon. This had already happened with the SendToKodi plugin, which i merged, but i had even greater reservations...

Anyway, i'm merging this for now, but with the caveat that i might revisit this decision in the future (and certainly also the inclusion of the SendToKodi one). The UI on the settings might change, or this might get removed - apologies in advance if that happens, but hope you understand the rationale.