search

xbmc / addon-check

Automatic checks for new repository submissions
GNU General Public License v3.0
52 stars 42 forks source link

Allow empty tags in addon.xml #133

Closed MartijnKaijser closed 6 years ago

MartijnKaijser commented 6 years ago

Some one decided that empty tags like website,forum,email are not allowed. That's just wrong and needs to be fixed as they are perfectly valid.

MartijnKaijser commented 6 years ago

fyi this is a high priority fix cause the wiki actually states that these tags are kind of required and currently the add-on checks states the opposite

razzeee commented 6 years ago

So it's just website, forum and email that need to be reverted? https://github.com/xbmc/addon-check/pull/118/commits/56d3b9fac8a06d442bdf76d7f722f8e2a58de25e

Edit: I guess these need also to be reverted license source broken news

razzeee commented 6 years ago

Then again, I would love for broken to be forced to be filled. Same for license.

Why is this required? Or is this a case of us just not wanting to change the wiki (and/or the fallout)?

MartijnKaijser commented 6 years ago

Lets ask the opposite. Why is it disallowed to have an empty tag? Why suddenly change a policy that's been around for years were we asked devs to start filling this out and if they didn't want to just keep the empty tag?

Broken should always be filled in if used. Never use the broken tag if you do not need it.

learningit commented 6 years ago

I guess the ultimate check for license is the actual license file itself, otherwise I would think license shouldn't be empty.

MartijnKaijser commented 6 years ago

Yes some are indeed mandatory and other are allowed to be empty. However forcing devs to remove empty tags should not be made compulsory

learningit commented 6 years ago

Agreed

enen92 commented 6 years ago

I agree too. There's no reason to be asking devs to fix their addon.xml when nothing is actually broken. I understand these changes were made to suggest devs to fill the tags (and with XSD it is either valid or invalid). We might want to suggest devs to fill those tags or remove them but definitely not block updates due to an empty tag that was there already (i.e. not in XSD validation).

enen92 commented 6 years ago

Can we agree on what tags may be empty? In my opinion:

Required not empty if used:

May be empty: (but we should report/advise that they could be filled)

I still do not understand why this was done. Has it something to do with the wiki or the addon-website?