Parially revert change that made some tags not able to be empty

xbmc / addon-check

Automatic checks for new repository submissions

GNU General Public License v3.0

52 stars 42 forks source link

Parially revert change that made some tags not able to be empty #140

Closed razzeee closed 6 years ago

razzeee commented 6 years ago

Closes #133

Rechi commented 6 years ago

I actually meant the following while talking about news https://github.com/xbmc/addon-check/blob/9d9b8d89159cfa86b33a06962a0daf8cd81afad1/kodi_addon_checker/xml_schema/gotham_metadata.xsd#L35

razzeee commented 6 years ago

I did understand that. So you want me to make it mandatory to fill it, but not to cap it?

razzeee commented 6 years ago

Okay, another update. Can we agree, to do it like this and change the wiki?

Rechi commented 6 years ago

If we change the wiki, I still not get why we would then require non empty strings for license, source and website, but not for email, forum, news and language.

I thought this whole PR is to keep the wiki as is, because otherwise the wiki could be changed for all elements and this PR wouldn't be needed.

MartijnKaijser commented 6 years ago

What is currently not according to the wiki?

Rechi commented 6 years ago

With the current state of this PR, max length for

description
disclaimer
news
summary

razzeee commented 6 years ago

Current state of PR only max lengths:

news

But I think the non empty stuff (no empty tags) for these are also not documented:

license
website
source
broken
news (again)
addon name
icon
fanart
screenshot
clearlogo
banner

razzeee commented 6 years ago

I would like to merge this as is any more comments?

Rechi commented 6 years ago

As already mentioned a few times in this PR, the wiki doesn't mention a char limit for news.

razzeee commented 6 years ago

Yes, thats what I'm going to change as soon as we merge this.