xbmc / addon-check

Automatic checks for new repository submissions
GNU General Public License v3.0
52 stars 42 forks source link

ignore .git folder in create_file_index #143

Closed Rechi closed 6 years ago

Rechi commented 6 years ago

Skip .git folder, which is inside the add-on path for single add-on repos (upstream repos), for for permission and whitelist checks.

fixes #123

razzeee commented 6 years ago

So this will also not report on .git folders that get PRed to our repo-* branches. Is that by design?

Rechi commented 6 years ago

Git doesn't allow to stage (git add) .git folders and therefore also not to commit them.

repo-scripts$ mkdir -p test/.git/
repo-scripts$ touch test/.git/test.txt
repo-scripts$ git add -f test/.git/test.txt
error: Invalid path 'test/.git/test.txt'
error: unable to add test/.git/test.txt to index
fatal: Hinzufügen von Dateien fehlgeschlagen