search

xbmc / addon-check

Automatic checks for new repository submissions
GNU General Public License v3.0
52 stars 42 forks source link

Add check for SPDX license identifier #144

Open mzfr opened 6 years ago

mzfr commented 6 years ago

Fixes #126 Should this be reported as a WARNING or just INFORMATION?

razzeee commented 6 years ago

Not too excited about this, as it will generate a flood of messages either way.

mzfr commented 6 years ago

Yes this will but another option is just say something like SPDX IDENTIFIER MISSING or one another thing I can think of, combine all the name of the files and print it like

SPDX Identifier missing from addon.py,addon1.py,addon2.py
mzfr commented 6 years ago

@Razzeee I'll add a check for license tag in addon.xml file but that would still generate lots of warning.

Should we ignore files if the tag is present in the addon.xml assuming developer knows about the identifier thing?

MartijnKaijser commented 6 years ago

License tag should already be mandatory. What this should do is see if doesn't match the SPDX format and suggest it. Same for the python files.

mzfr commented 5 years ago

@Razzeee Is there any other changes required in this PR?

razzeee commented 4 years ago

Do we really want these two checks?

a) Not looking forward to having to have a license string in every file b) Shouldn't be forcing a GNU license, like rechi correctly mentioned