add url (forum, source, website) check

xbmc / addon-check

Automatic checks for new repository submissions

GNU General Public License v3.0

52 stars 42 forks source link

add url (forum, source, website) check #154

Closed Rechi closed 5 years ago

Rechi commented 5 years ago

As https://kodi.tv/addons and kodi.wiki lists forum, source and website from addon.xml those should be valid urls. @enen92 if wanted I can change the errors to warnings, so that the url validation never fails a check.

Rechi commented 5 years ago

The reason for implementing this, was that someone searched the upstream repo for an add-on, but the url in the addon.xml was wrong and pointed to a 404 page. You may want check the logs about how many invalid urls are listed in the addon.xmls.

razzeee commented 5 years ago

Okay, not very surprising. Code read and previous interactions sounded like we're afraid to link to problematic websites.

anxdpanic commented 5 years ago

Wouldn't using requests.get() here instead of requests.head() leave this open to abuse? ie. multiple PRs with forum/website/source all point to > 1GB files

Sorry for creating noise if I missed something here.

Rechi commented 5 years ago

@anxdpanic Thanks for the hint. Now a the check runs also quicker.