search

xbmc / addon-check

Automatic checks for new repository submissions
GNU General Public License v3.0
52 stars 42 forks source link

kodi-addon-checker.log (Found non whitelisted file ending in filename) reported on PR test #156

Closed anxdpanic closed 5 years ago

anxdpanic commented 5 years ago

Started integrating TravisCI/addon-check into some repositories, currently quite a few false problems/warnings. It looks like the .git folder is ignored in master(which would resolve most false reports), but I don't see anything addressing the log file in master. See: https://travis-ci.org/jdf76/plugin.video.youtube/jobs/485145419#L520

razzeee commented 5 years ago

Jep, needs to be ignored by the full name I guess.

Still fells like we need more then --PR and not setting that. As far as I know we have at least three cases:

Might be nicer if we can change that commandline option. And the things we need to change for the last case should only be removing git from the scan.

See https://github.com/xbmc/addon-check/issues/123 for the other problem.

anxdpanic commented 5 years ago

Noticed a couple other ERROR reports, that could probably be INFO for single addon folder PR

ERROR: Addon id and folder name does not match. (eg. Twitch-on-Kodi/plex-for-kodi) and ERROR: plugin.video.twitch addon already exists with version: 2.4.1 in isengard branch

https://travis-ci.com/MrSprigster/Twitch-on-Kodi/builds/98843745#L502 (Line 503 and 504)

Rechi commented 5 years ago

ERROR: plugin.video.twitch addon already exists with version: 2.4.1 in isengard branch

That's exactly the use case of the --PR command line argument. It's not expected that you run your checks always with --PR. It's only for our repos to check that the version is actually increased in a PR.

anxdpanic commented 5 years ago

Okay, so --PR shouldn't be used on PR's outside of the official repo? I'm using it on PR's like in the above log, based on the argument description and https://github.com/xbmc/addon-check/blob/master/.travis-addon.yml.example

Rechi commented 5 years ago

Yes you shouldn't use that. The only location it is used the following (forcing strictly higher version). https://github.com/xbmc/addon-check/blob/09298318e9423940c0b740e3c5acc775b0d7077a/kodi_addon_checker/check_old_addon.py#L46-L59

anxdpanic commented 5 years ago

@Rechi Thank you for the clarification. I've updated where necessary 👍

Rechi commented 5 years ago

@anxdpanic a new version was released which includes the .git folder fix.

anxdpanic commented 5 years ago

I was looking at adding something to resolve the mentioned log/license warnings I had a couple ideas on how to approach this;

  1. --exclude-file and --exclude-file-ext to exclude file/folder and extensions from permissions and extension whitelist
  2. --whitelist-file and --whitelist-file-ext to exclude from extension whitelist
  3. both

This would also allow for .pyo/.pyc to be ignored as well when done against a folder

Any suggestions on how this should be approached?

edit: The .git folder fix cleaned up the log quite a bit 👍
https://travis-ci.org/MrSprigster/Twitch-on-Kodi/jobs/488168484

anxdpanic commented 5 years ago

I was able to resolve the initial issue (log and license) within travis ci, https://github.com/jdf76/plugin.video.youtube/blob/master/.travis.yml#L14 https://travis-ci.org/jdf76/plugin.video.youtube/builds/491251610

anxdpanic commented 5 years ago

This issue was resolved locally and ci outside of kodi-addon-checker