Closed anxdpanic closed 5 years ago
Should be fine for the kodi repo usecases, but probably won't work for the ci of single repos.
I don't like this autodetection mode. Actually --PR
argument should be renamed to --higher-version-required
or something like that.
If the folder id check should be ignored, it needs it's own command line argument. ~But as this is only reported as warning, I don't see the actual need. This warning (alone) will never result in a non zero exit code.~ (Edit only looked at he new code)
Should I change this to have it's own argument --skip-folder-matches-id
and change the warning to info?
Yes it should be changed to have it's own argument.
The name --skip-folder-matches-id
would make me think that actually executing the addon_xml_matches_folder
function is completely skipped, not that reports a warning or info instead of an error. But that's nothing I care much about.
Any feelings on warning vs info? I went with warning here since it's a must when submitting.
Updated to use --allow-folder-id-mismatch
, also changed reporting to INFO since it requires the argument to override now
The following line needs an update too. https://github.com/xbmc/addon-check/blob/ad8aa4960a0fefdb2f4661ff9fd7f2e90427e445/tests/test_check_addon.py#L26
Updated test_check_addon, required adding an Args
class as well
The new argument needs to be documented in the readme
Added to the readme and shifted the description alignment accordingly
thank you!
w/ arg:
INFO: Addon id and folder name does not match. Ensure folder name is <addon_id> when submitting a PR to Kodi's official repository.
w/o arg:
ERROR: Addon id and folder name does not match.