search

xbmc / addon-check

Automatic checks for new repository submissions
GNU General Public License v3.0
52 stars 42 forks source link

Checker should error out if no en_gb file is found in translation #238

Closed enen92 closed 4 years ago

enen92 commented 4 years ago

The addon checker should error out if the addon is using the new folder language layout and doesn't include a en_gb strings.po file. This is the case of @sarbes plugin.audio.wdr3konzert/ in matrix where en_US is included: https://github.com/xbmc/repo-plugins/tree/matrix/plugin.audio.wdr3konzert/resources/language. en_GB is the default language for kodi since krypton, so it's presence if the addon includes localized strings is mandatory. Not including it and requiring translations, make the listitem labels empty

I'll pick this one myself once I find some time

Space2Walker commented 4 years ago

I have a somewhat related issue. The addonchecker should error with a broken path to the strings.po file, and not say "INFO: PO files are valid" when kodi cant load them. For more info's see Kodi-Forum.

anxdpanic commented 4 years ago

I have this staged locally to resolve both issues, needs some refactoring to satisfy pylint. will PR when I have it ready

Space2Walker commented 4 years ago

Thanks for the quick response and fix @anxdpanic.