search

xbmc / audiodecoder.sidplay

Sidplay decoder addon for Kodi
GNU General Public License v2.0
5 stars 8 forks source link

[LE8.02] Kodi restarts when addon is loaded #15

Open nRaecheR opened 7 years ago

nRaecheR commented 7 years ago

I've installed the latest version of this add-on from Kodi/LibreElec Repositories but Kodi restarts whenever I enter a directory with SIDs in it. I've mapped themm as NFS storage from my server.

Environment: LibreElec 8.02, offiicial AMD64 build on Intel NUC with Apollo Lake CPU

Kodi Log with Debugging enabled: 

15:23:35.891 T:140095039015040   DEBUG:   ParentPath = [/storage/music/Soundtrack/Gamez/C64/SID/GAMES/]
15:23:35.924 T:140095039015040   DEBUG: ADDON: Dll Initializing - Sidplay Audio Decoder
15:23:35.928 T:140095039015040  NOTICE: ADDON: Loaded virtual child addon special://temp/audiodecoder.sidplay-0.0
15:23:35.928 T:140095039015040   DEBUG: SECTION:LoadDLL(special://temp/audiodecoder.sidplay-0.0)
15:23:35.928 T:140095039015040   DEBUG: Loading: /storage/.kodi/temp/audiodecoder.sidplay-0.0

Anything I can do to prevent this restart and listen to good old SIDs on my Kodi installation?

notspiff commented 7 years ago

can you get me the crash log ?

nRaecheR commented 7 years ago

I would like to but no crash log will be generated when Kodi restarts. Is there anything I can do to force the generation of it?

notspiff commented 7 years ago

hmm. that would be icky with LE. i will have to see if i can reproduce based on your instructions.

nRaecheR commented 7 years ago

I've a couple of crash logs but not a single one related to Sidplay. It seems Kodi simply restarts without any sign of a crash and any relevant information in the kodi.log.

notspiff commented 7 years ago

could it be that /storage is mounted noexec on le ?

nRaecheR commented 7 years ago

I don't think so, here the output 'mount':

devtmpfs on /dev type devtmpfs (rw,relatime,size=3997072k,nr_inodes=999268,mode=755)
proc on /proc type proc (rw,relatime)
sysfs on /sys type sysfs (rw,relatime)
/dev/sda1 on /flash type vfat (ro,noatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,errors=remount-ro)
/dev/sda2 on /storage type ext4 (rw,noatime,data=ordered)
/dev/loop0 on / type squashfs (ro,relatime)
tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
tmpfs on /run type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /sys/fs/cgroup type tmpfs (ro,nosuid,nodev,noexec,mode=755)
cgroup on /sys/fs/cgroup/systemd type cgroup (rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd)
cgroup on /sys/fs/cgroup/cpu,cpuacct type cgroup (rw,nosuid,nodev,noexec,relatime,cpu,cpuacct)
cgroup on /sys/fs/cgroup/devices type cgroup (rw,nosuid,nodev,noexec,relatime,devices)
cgroup on /sys/fs/cgroup/perf_event type cgroup (rw,nosuid,nodev,noexec,relatime,perf_event)
cgroup on /sys/fs/cgroup/blkio type cgroup (rw,nosuid,nodev,noexec,relatime,blkio)
cgroup on /sys/fs/cgroup/memory type cgroup (rw,nosuid,nodev,noexec,relatime,memory)
cgroup on /sys/fs/cgroup/freezer type cgroup (rw,nosuid,nodev,noexec,relatime,freezer)
cgroup on /sys/fs/cgroup/cpuset type cgroup (rw,nosuid,nodev,noexec,relatime,cpuset)
debugfs on /sys/kernel/debug type debugfs (rw,relatime)
tmpfs on /var type tmpfs (rw,relatime)
tmpfs on /tmp type tmpfs (rw,nosuid,nodev)
mqueue on /dev/mqueue type mqueue (rw,relatime)
<server-ip>:/srv/Music on /storage/music type nfs (rw,relatime,vers=3,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=2049,timeo=70,retrans=3,sec=sys,local_lock=none,addr=<server-ip>)
notspiff commented 7 years ago

okay, good.

notspiff commented 7 years ago

what is the kodi revision you are running?

nRaecheR commented 7 years ago

Here's the complete header from the lodi.log file:

10:21:08.308 T:140014467926144  NOTICE: special://profile/ is mapped to: special://masterprofile/
10:21:08.308 T:140014467926144  NOTICE: -----------------------------------------------------------------------
10:21:08.308 T:140014467926144  NOTICE: Starting Kodi (17.3 Git:147cec4). Platform: Linux x86 64-bit
10:21:08.308 T:140014467926144  NOTICE: Using Release Kodi x64 build
10:21:08.308 T:140014467926144  NOTICE: Kodi compiled May 25 2017 by GCC 6.2.0 for Linux x86 64-bit version 4.9.29 (264477)
10:21:08.308 T:140014467926144  NOTICE: Running on LibreELEC (official) - Version: 8.0.2, kernel: Linux x86 64-bit version 4.9.29
10:21:08.308 T:140014467926144  NOTICE: FFmpeg version/source: ffmpeg-3.1-kodi
10:21:08.308 T:140014467926144  NOTICE: Host CPU: Intel(R) Celeron(R) CPU J3455 @ 1.50GHz, 4 cores available
10:21:08.308 T:140014467926144  NOTICE: special://xbmc/ is mapped to: /usr/share/kodi/
10:21:08.308 T:140014467926144  NOTICE: special://xbmcbin/ is mapped to: /usr/lib/kodi
10:21:08.308 T:140014467926144  NOTICE: special://xbmcbinaddons/ is mapped to: /usr/lib/kodi/addons
10:21:08.308 T:140014467926144  NOTICE: special://masterprofile/ is mapped to: /storage/.kodi/userdata
10:21:08.308 T:140014467926144  NOTICE: special://envhome/ is mapped to: /storage
10:21:08.308 T:140014467926144  NOTICE: special://home/ is mapped to: /storage/.kodi
10:21:08.308 T:140014467926144  NOTICE: special://temp/ is mapped to: /storage/.kodi/temp
10:21:08.308 T:140014467926144  NOTICE: special://logpath/ is mapped to: /storage/.kodi/temp
10:21:08.308 T:140014467926144  NOTICE: The executable running is: /usr/lib/kodi/kodi.bin
10:21:08.308 T:140014467926144  NOTICE: Local hostname: NUC
10:21:08.308 T:140014467926144  NOTICE: Log File is located: /storage/.kodi/temp//kodi.log
10:21:08.310 T:140014467926144  NOTICE: --------------------------------------------------------
notspiff commented 7 years ago

i can reproduce the behavior. LE is likely to blame. you cannot use the latest audiodecoder.sidplay with kodi 17.3, latest tagged version (1.1.0) works fine. please check if this is the problem.

nRaecheR commented 7 years ago

Okay, thank you. How do I get the working version (1.1.0) on the device. Is there any way to 'downgrade' an add-on from the repo?

notspiff commented 7 years ago

i think it's unlikely that LE offers older builds out of the repo. @stefansaraev any clue ?

stefansaraev commented 7 years ago

from what I can see, LE ~8.2~ 8.0.2 ships audiodecoder.sidplay from git 3e8a22e which is exactly the 1.1.0 tag.

notspiff commented 7 years ago

in that case i reproduced a different issue. i cannot get it to crash for me, neither using local files nor using the vfs (ssh not nfs but should be the same).

nRaecheR commented 7 years ago

I see, what can I do to track down the issue? Providing more log files with more debugging options enabled? Why is no kodi crash log generated when it restarts?

nRaecheR commented 7 years ago

I will try it later with a local copy of my SID collection, directly on my LE device.

One thing I need to notice is that the nfs share is mounted through systemd from LE, not from KODI itself. And it's a read-only share, so no possibility to write anything to it from LE/KODI. Is that an issue?

nRaecheR commented 7 years ago

Tested it with a local copy of the SID files directory, the crash happens here too. It has nothing to do with the network access and I think it should be fairly easy to reproduce it because my LibreElec installation is pretty standard.

nRaecheR commented 7 years ago

Same with LE 8.10 BETA/Kodi 17.4-rc1

sm0yyq commented 5 years ago

Hi, Can also agree to the fact this addon doesent seem to work in diffrent distro's. I have tried newest, and older version of LibreElec on mine RPI 3B+with no sucess, kodi restarts (no hard reset) evry time i acess a directory with sidfiles.

I have also tried OpenElec on my RPI with same results. I have also tried the X86 versions of LibreElec and OpenElec with same result, kodi restarts whan acessing sid file directories.

Only version i have got running is newest Kodi on my Windows 7 machine and it worked perfect.

So i guess u have to sit down and figure out thats wrong cose i realy should like to have sid music playing on my RPI3 b+ with HIFIBARRY mouted on it.

escalade commented 5 years ago

I've investigated the LibreELEC issue as I have reproduced it on my XU4. It seems to be a static linking (possibly cmake or toolchain) issue:

Jun 18 22:17:58 XU4 kodi.sh[4768]: /usr/lib/kodi/kodi.bin: symbol lookup error: /storage/.kodi/addons/audiodecoder.sidplay/audiodecoder.sidplay.so.1.1.3: undefined symbol: _ZN8sidplay2C1Ev

Compiling the sidplay-libs package as a shared library and either including libresid-builder.so.0 in the addon or preloading it using LD_PRELOAD works and I can play SID files without Kodi crashing.

AlwinEsch commented 4 years ago

Will the days look what's exactly there. Had with my recent changes only to Windows, Mac, Linux (Ubuntu) and Android tested (there it went).

Then I go through this and other addons to see how they behave on LibreELEC/Raspberry.

sm0yyq commented 4 years ago

Hey all, any update on this?, .. any sucess to make it work on LibreELEC (Rasperry PI) ?

escalade commented 4 years ago

Well I did post two workarounds.

sm0yyq commented 4 years ago

escalade: Well, i know.. but i dont know if somthing was made of it..?

Anyway i have tried the LibreELEC 9.2 on my RPI3 and trying out the sid plugin by SPIFF Version 1.2.2.

It starts up with an error again complaining it cant start the plugin, i have tried the 3 diffrent versions with same result.

nRaecheR commented 4 years ago

@escalade It would be great if you could have a look at the package.mk of the sidplay plugin in LE. You seem to have found the reason or at least a workaround for the problem and it would be really appreciated if this fix can be implemented in LE. Thank you!