search

xbmc / audioencoder.lame

Lame MP3 encoder addon for Kodi
GNU General Public License v2.0
5 stars 13 forks source link

Charset problem #38

Closed masterbug closed 2 years ago

masterbug commented 3 years ago

Hello,

Like this addon. But I have a problem, it does not handle äöü and so on correctly. The ACC encoder does it right. Maybe you can apply the same charset handling also to the Lame Encoder. The Filename appears correct, but Kodi displays it wrong. As far as I know this is because of wrong or false charset handling. Applies to 2.0.x and also to 3.x regards Masterbug

masterbug commented 3 years ago

Here is a picture: image And when I display the same in FileExplorer: 001CF864-93CB-4FA0-B6FA-712A9C7829AD

AlwinEsch commented 3 years ago

Have something about in mind. I look to fix it, which OS you used about?

AlwinEsch commented 3 years ago

If you have Windows, OSX or Android, can you take for test purposes a zip from from here and install by you for test?

About company work I'm currently not at home (Hotel room) and not have CD's for test available.

I'm created on https://github.com/xbmc/audioencoder.lame/pull/40 an request where becomes the latest liblame added, badly they have on them still no new releases, but if it works, maybe we find a way.

masterbug commented 3 years ago

Hello, sorry for the late reply.
it is great to see somebody is looking in this. I use LibreElec generic for my AllinOne PC. Is there a way to test it with this device?

may I test with Nexus builds? rgds Masterbug

AlwinEsch commented 3 years ago

A little more difficult, I'll buy a CD tomorrow and test it. Funnily enough, I'm back for work and home is far away (Saarbrücken at home, and 2 weeks back to work in Frankfurt) :sweat_smile: .

Hadn't thought of it at home either.

masterbug commented 2 years ago

Hi, I can also send you a CD of Benjamin Blümchen. This works well to demonstrate its issue. Greetings Meanwhile I am on Libreelec 10 with Kodi 19.1 using Lame MP3 Audio Encoder 19.0.0.1 by spiff.

AlwinEsch commented 2 years ago

Have becomed it fixed now and here a fix request about https://github.com/xbmc/audioencoder.lame/pull/44.

The UTF-8 was come in strange format, not only in Kodi, also VLC has shown wrong. The fix sets the string format to UTF-16 and with them it has shown correct.

AlwinEsch commented 2 years ago

Have brought in the fix requests to Matrix and Nexus version. Hope the libreelec includes soon the update about.

masterbug commented 2 years ago

This is good to know. Thank you for your work.

masterbug commented 2 years ago

Hello, With the release of Libreelec 10.0.2 the fix reached finally my device as well. I can now rip Benjamin Blümchen. Thank you for your effort.