xbmc / chorus2

Official Kodi Web Interface
GNU General Public License v2.0
343 stars 116 forks source link

Some adds and fixes for de.po and en.po #501

Closed driet closed 2 years ago

gade01 commented 2 years ago

@driet Thanks for the PR.

Language updates and translations should be done at Weblate: https://kodi.weblate.cloud/projects/kodi-web-interfaces/chorus2/ This will keep consistency and avoid errors.

Feel free to sign up and submit your changes there. German language team is quite large and @ksooo is coordinating it.

driet commented 2 years ago

@gade01 You're welcome, I checked in once in a while and mostly did the german translation for Chorus2. Signed up for weblate. Will do the work again (no import function?).

What about the double entrys in the .po files ("mood") and deleting some lines in the .po header? Can't be done in weblate?

Validation in weblate may not be as good as in other tools, yet.

gade01 commented 2 years ago

@driet That sounds great, thanks again. Glad to have you at Weblate as well. I know @ksooo prefers changes done as suggestions as the team is very large.

No, there's no import function for translators. Only moderators and reviewers/coordinators have that option.

Only the source en file (https://github.com/xbmc/chorus2/blob/master/src/lang/_strings/en.po) have to be changed by PR's at Github. I don't know anything about it, but can see that there are several duplicated strings. Weblate points this out as well.

Once the source file is changed, Weblate will sync the other languages.

gade01 commented 2 years ago

@driet As far as I'm concerned, you could leave the change for en in this PR and remove de changes (they are done at Weblate). Then we could merge it ;)

driet commented 2 years ago

@gade01 Unfortunatly I am a git noob without a local git. I used the website fork to PR and don't see, where to remove the commit. So it's maybe best to just close the PR?

gade01 commented 2 years ago

No worries. :) Yeah, maybe it's easiest to close this PR and create another with en file changes.