search

xbmc / elm-chorus

A web interface for Kodi/XBMC written in Elm
GNU General Public License v2.0
21 stars 19 forks source link

Implemented sort functionality for the remaining pages #110

Closed developingright closed 2 years ago

developingright commented 2 years ago

Hi @razzeee, I have implemented the sort functionality for the remaining pages, with this PR the issue (#99) will get completed. It would be great if you could review it, Thank you. :slightly_smiling_face:

razzeee commented 2 years ago

Movies and tvshows have a bunch more sort options we're still missing in this as far as I can tell?

developingright commented 2 years ago

Hi @razzeee, Yes, the reason for being is that in the existing codebase, Movie and TvShow Objs don’t support the field such as dateadded, etc. I have implemented the sort functionality for the Objs based on the existing fields. I was thinking we can create a new issue where we can address this problem and add fields to the Objs by modifying the Decoders in order to fetch the other fields. Once, this has been done then creating a sorting method and front-end for the same should be a trivial task. Since, the new issue is not related to the sort functionality as it’s about adding additional fields to the objects I was thinking that we can address it in another MR. I would love to know your thoughts on this.

razzeee commented 2 years ago

Sounds perfectly fine, just making sure it doesn't get lost.