Added common logging, settings, translations and jsonRPC boilerplate

xbmc / generator-kodi-addon

Yeoman generator for the most common Kodi addon types.

http://www.kodi.tv

Other

74 stars 25 forks source link

Added common logging, settings, translations and jsonRPC boilerplate #6

Closed razzeee closed 7 years ago

razzeee commented 7 years ago

This adds a bunch of boilerplate for plugins, services and scripts. Only the service example will use something from this (logging).

This code is taken from my trakt script. With the logging stuff taken from @tamland

Please review and let me know if there are things to improve @enen92 @phil65 @phate89

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 3c0a0692288186d9a30fdcbd3cf034afd5874a3a on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 3c0a0692288186d9a30fdcbd3cf034afd5874a3a on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

phate89 commented 7 years ago

Isn't better instead of adding it to ask tamland to create a module and add that dependency? It seems a very good logging other projects could use..

MartijnKaijser commented 7 years ago

Imo its plain stupid we even have to build a module around our Kodi python module to make it usable. That clearly shows it needs to get fixed and not build something around it. Also most of this stuff is quite pointless as it's nearly duplication of what is already provided by the api

razzeee commented 7 years ago

@MartijnKaijser while that would be the best approach, that won't help us know or with already released versions

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 805ec127ea50a11ffa6892b44526ae2cccd2ce39 on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 83c38e53cf2c471ffc1218b12b54a29da0895feb on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 89c0a60071e8837f49ad72868b1cbc9b3146dd31 on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 289e740e840920ee61cfee2a31407b77c53ebb3b on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 289e740e840920ee61cfee2a31407b77c53ebb3b on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling a0479fd3712dba56e429aa314cea72b32a901f0d on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling a0479fd3712dba56e429aa314cea72b32a901f0d on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 06577821027891612895799abe039f5bed204c7e on common-boilerplate into 761f4d79ce176b87b94af401b12dd46423c1b2a6 on master.