Multispan subtitle fix only in Matrix branch, not in Leia

[dagwieers]

Apparently this fix (https://github.com/peak3d/inputstream.adaptive/commit/f90cab170e32476f8b70c284e2134b18b89bcdbb) appears to be merged only for Matrix, but not for Leia.

Would it be possible to have these fixes also for Leia ?

[dagwieers]

cc @peak3d @mediaminister What is needed to get this fixed? This was merged in July 2019, would be nice to see it in Leia.

[peak3d]

@dagwieers someone has to do the work picking relevant PR's / commits from master branch, runtime test them, and create a PR. I don't have such streams in daily usage, so it's hard for me to runtime-test

[dagwieers]

@peak3d Thanks for making that clear!

• Could we bring together the different (Leia) stakeholders? (Those who need newer functionality, and those who rely on existing functionality) And see how we can tackle the testing requirements.
• Who would be the usual suspects for this?
• What could we do to make this a collaborative effort?

One of the known issues is the lack of automated build for LibreELEC RPi (ARM). Is there anything we can do or anyone to speak to to make this possible?

cc @michaelarnauts @peno64 @mediaminister @CastagnaIT @basrieter

[peak3d]

I can try to create a PR tonight, but as said, it must be tested - I'm not on 18.x anymore...

[CastagnaIT]

there are also the my two WebVTT fixes (one in waiting of approve) to port to Leia branch, I can do the PR to merge on Leia if @peak3d approve a backport

if you need, i can do build manually for testing but only for Win-x64

[dagwieers]

@peak3d The majority of users are still on Leia, so we (add-on developers) are mostly focussed on Leia. A separate branch for testing would be useful (especially if we could have RPi builds) else someone needs to build and share these builds (which may be confusing wrt. version which is problematic for sharing test results).

In any case, none of the add-on developers want to see their offering break, so more/better testing is a given.

Not sure if we can have special versions for test builds? For our add-ons we have names like plugin.addon-<version>-<branch>-<commit>.zip.

plugin.video.vrt.nu-2.3.0-metadata-fixes-e8ac187.zip
plugin.video.vrt.nu-2.3.1-master-9893882.zip
plugin.video.vrt.nu-2.3.2-assorted-fixes11-c353fb9.zip
plugin.video.vrt.nu-2.3.2-search-edit-dcb773d.zip
plugin.video.vrt.nu-2.3.2-radio2-live-051bb64.zip

[peak3d]

Ok, I'll prepare a leia-backport branch with a bumped version for testing. @CastagnaIT I'll merge / backport your PR's, too

[CastagnaIT]

well, i will do the PR with the backports

[dagwieers]

Do we have a list of (popular) add-ons that require inputstream.adaptive? It would be best to reach out to as many stakeholders as possible once we have a release candidate available.

[peak3d]

I don't, sorry, I can try ta place a post in kodinerds forum, there are a bunch of them

[dagwieers]

@peak3d Are you willing to open up the Wiki for outsiders (or collaborators) so we can start collecting/organizing using the Wiki?

PS I use Netflix, Retrospect, VRT NU and VTM GO which all depend on inputstream.adaptive

[dagwieers]

Thanks @peak3d, I made a list here: https://github.com/peak3d/inputstream.adaptive/wiki/Stakeholders

[peak3d]

• wiki is open
• branch Leia-backport (version 2.4.3) is created (dump master merge, let's see if it works) Jenkins already build artifacts.

[peno64]

I will try to compile the leia_backport branch this evening on raspberry pi and see if it works ok on kodi 18.5 on libreelec. I can try then the following addons : vrt nu retrospect yelo tv vtm go catch up tv and more

[peno64]

@dagwieers I think the amazon prime kodi addon also uses inputstream adaptive. I don't see it on your wiki list

[CastagnaIT]

I have tried to install the artifact on Kodi18-win64 but the first time that i tried to update ISA, a notification say problems with dependencies in the addon.xml the requires imports are different as usual

i have tried to modify the requires imports with the old one then the installation of zip is ended right way, but when i try to play a video on netflix say that the inputstream is not compatible with this version of Kodi

[peak3d]

thx @CastagnaIT then I'll have to look more in detail

[peak3d]

There was something wrong in Jenkinsfile - change pushed

[CastagnaIT]

I suspected something like this well i will wait the new build

[peno64]

I compiled the inputstream.adaptive Leia_backport branch successfully on raspberry pi and installed it on LibreElec with kodi 18.5 and all seems to be working. It can be found here: http://users.telenet.be/peno/kodi/addons/inputstream.adaptive/ I tried the following addons:

vrt nu retrospect yelo tv vtm go catch up tv and more

All works fine but with vtm go from (@michaelarnauts) I still have the problem that I have to pause a second or two at the start of a program when the commercial starts and then just after when the commercial is done again two seconds and then I can play without a problem. This is still the same effect as with the version I compiled on september 2019 So in fact I don't see any difference at all between the two versions. The positive thing about this new version is that it is now version 2.4.3 while that version in september last year was still 2.4.0

Subtitles also work and scrolling foreward also but that also worked in the september version.

@dagwieers Is there anything specific I can test with this version that should work better now? The title of this bug says "Multispan subtitle fix only in Matrix branch and not in Leia". How can I test if this is now ok? What was exactly the problem

[peak3d]

The issue with commercials is inside kodi, it appears if the internal 8 second queue contains more than one new stream (change). IIRC it is still not fixed in master, and therefore not backported.

[peno64]

@peak3d : Thanks for the explanation. Good to know this is a known issue.

[dagwieers]

@peno64 It happens from time to time. I cannot give you an existing stream that was affected by it as I don't remember when/where I saw it last.

I think the most important event here is that we're testing the upcoming v2.4.3 with a lot of fixes we want to see released (soon). If we are happy with this release, let us involve the other stakeholders to test this release.

@peak3d Do you expect more changes that ought to go in the upcoming v2.4.3, or is this it?

[dagwieers]

Just for the record, there is also a known issue where the sound picks up seconds later when seeking (backward) or starting playback. Should we keep a list in the Wiki of things we know are not working? At least we can test for this specifically to see the scope of known issues.

PS I also added a Wiki page with testing instructions. I am pretty sure there is more to test! https://github.com/peak3d/inputstream.adaptive/wiki/Test-plan

[dagwieers]

@peno64 Could you rename your build to inputstream.adaptive-2.4.3-<commit>.zip ? It may help supporting testers when issues arise (and we have to create more builds).

[peno64]

@dagwieers . Sure I can, but what is < commit > ?

[dagwieers]

@peno64 The (last) commit hash of the tree you build your binary from (currently it is 0a07161). It would also be nice if we could have all fragments from Jenkins in a single location, with the same version in the filename. It will help when asking people to test this version.

So this would be: inputstream.adaptive-2.4.3-0a07161.zip (if that was the last commit in the branch)

[CastagnaIT]

i have tested the new build of Leiabackport (following test points) with Netflix addon on; Win-x64 Android64 on a android 8.0 smartphone (720P/1080P)

seems to be working as usual, perhaps need more testing on android with device like Shield and a 4k hardware (i do not have)

[dagwieers]

@CastagnaIT Great, we need a page on the wiki to collect test results from people for different platforms and add-ons. I will create that page now.

[dagwieers]

So I created a Wiki page for collecting test results at: https://github.com/peak3d/inputstream.adaptive/wiki/Test-results

When we are happy with the Wiki pages and the Leia branch is ready as a release candidate, we can involve all stakeholders for testing.

@peno64 Can you add your test results?

[peno64]

@dagwieers : It is renamed I will add test results this evening

[peno64]

@dagwieers would inputstream.adaptive-Leia_backport-2.4.3-0a07161.zip not be a better name?

[dagwieers]

@peno64 It depends, more information is not always better. Is "backport" relevant here?

Maybe inputstream.adaptive-2.4.3-leia-0a07161 ?

[peno64]

@dagwieers inputstream.adaptive-2.4.3-leia-0a07161.zip it is

[dagwieers]

@CastagnaIT There is a lot of relevant information for end-users in the Netflix add-on README which I think would benefit everyone. Are you interested to contribute and maintain this in the inputstream.adaptive Wiki?

Likewise the information from the VRT NU wiki related to Bandwidth and HD quality is also a candidate to be maintained on the inputstream.adaptive wiki.

[CastagnaIT]

I can contribute but not maintain update, I don't know the full functionality of ISA in detail, you could start writing something but it will have to be reviewed by Peak3D

Most (final)users don't come here for problems with video playback, but always refer to the github of each video addon, in this wiki you should expand the "Developer Documentation"

with pages for each DRM like example: Title: DRM - Widevine ( or PlayReady etc) Contents charapters: -Os supported -How install (with helper or other modality?) -How integrate -Feature/limitations based on operative systems

it would be appropriate to dedicate a separate page for "4K HDR DolbyVision" for direct reference on how to implement, that explain which drm support this features and under what conditions (Kodi versions, OS, device characteristics, etc) and how set the dash properties

[peno64]

@peak3d You said: "The issue with commercials is inside kodi, it appears if the internal 8 second queue contains more than one new stream (change)."

If that is the case, why does this issue does not happen with kodi under Windows? I only have it with kodi on raspberry pi (libreelec)

[peak3d]

I have this issue under windows, too, it depends sometimes on processing speed. It's not every time, multiple things play together there.

[dagwieers]

@peak3d Correct, it's non-deterministic behavior.

[dagwieers]

Are we ready to call out to all stakeholders to help in testing this Leia release with their add-on on different platforms?

[dagwieers]

@peak3d Would it be possible to get privileges to label issues in this project? I think it would be worthwhile to start adding labels related to type, technology, platform, status, etc.

Update: You can see in this project how we do this: https://github.com/pietje666/plugin.video.vrt.nu/issues

[dagwieers]

This can be closed.