search

xbmc / inputstream.adaptive

kodi inputstream addon for several manifest types
Other
450 stars 241 forks source link

[Dash] Support urn:scte:da sh:cc:cea-608:2015 (CEA-608 captions) #782

Open matthuisman opened 3 years ago

matthuisman commented 3 years ago

https://github.com/google/shaka-player/issues/1404 https://dashif.org/identifiers/subtitle_and_closed_captioning/

seems kodi does support them: https://forum.kodi.tv/showthread.php?tid=359024 https://forum.kodi.tv/showthread.php?tid=330882

So maybe we just need to check for the value and set the name etc.

<AdaptationSet id="1" mimeType="video/mp4" segmentAlignment="true" bitstreamSwitching="true" maxWidth="1280" maxHeight="720" maxFrameRate="60000/1001">
    <Accessibility schemeIdUri="urn:scte:dash:cc:cea-608:2015" value="CC1=eng"/>
    <ContentProtection schemeIdUri="urn:mpeg:dash:mp4protection:2011" value="cenc" cenc:default_KID="664c5cf680145605888b30b76cd2e568"/>
    <ContentProtection schemeIdUri="urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95"/>
    <ContentProtection schemeIdUri="urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed"/>
    <SegmentTemplate timescale="90000" media="https://live-f.hulustream.com/VICE-MLB/VICE-MLB_146726828024220/$RepresentationID$/$Time$_video.m4s" initialization="https://live-f.hulustream.com/VICE-MLB/$RepresentationID$_10_video_init.mp4">
        <SegmentTimeline>
            <S t="2775830777" d="450450" r="21"/>
            <S d="495495"/>
        </SegmentTimeline>
    </SegmentTemplate>
    <Representation id="VICE-MLB_VIDEO_7_1200000" codecs="avc1.4d001f" width="640" height="360" startWithSAP="1" bandwidth="1322000" frameRate="30000/1001">
</Representation>
</AdaptationSet>

Hulu live channels seem to use these

yeahme49 commented 2 years ago

Not sure if there is anything in the works yet for this, but would love to see it get added. Discovery+ USA uses CEA-608 captions as well so they are not working as of now.

CastagnaIT commented 2 years ago

i think has been finally found the problem of the start code that prevent load CC subtitles at least from my test now works please let a feedback after https://github.com/xbmc/xbmc/pull/21410 PR will be merged

matthuisman commented 2 years ago

Oh wow. That's great. I'll test once it's merged

matthuisman commented 2 years ago

Now merged. Should be in next nightly KodiSetup-20220517

Also see Matrix backport done. That should also be in next 19 nightly

enen92 commented 2 years ago

@matthuisman fix confirmed?

matthuisman commented 2 years ago

I no longer have access to a Hulu login with tv subscription so wasn't able to confirm unfortunately :(

On Fri, 20 May 2022, 20:26 Miguel Borges de Freitas, < @.***> wrote:

@matthuisman https://github.com/matthuisman fix confirmed?

— Reply to this email directly, view it on GitHub https://github.com/xbmc/inputstream.adaptive/issues/782#issuecomment-1132625570, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPQAKKHFXKF4MIQYJ7XOL3VK5ECFANCNFSM5DBJTMYQ . You are receiving this because you were mentioned.Message ID: @.***>

CastagnaIT commented 2 years ago

can you maybe try ask to some user in kodi forum?

matthuisman commented 2 years ago

ok, managed to get a login to test with

KodiSetup-20220520-43b96fc2-master-x64.exe ISA 20.2.1

Not working unfortunately. No subs at all. Files attached that hopefully will help

kodi.log.txt manifest.mpd.txt VIDEO_2_8800000_3_86a1050eef074667a44a2220678642a5_cenc_video_init.mp4.txt 148781520527640_cenc_video.m4s.txt

CastagnaIT commented 2 years ago

video file is encrypted we should find a unencrypted sample to try debug cc demuxer in kodi core

enen92 commented 1 year ago

I am still interested in samples or accessing streams (temporarily) which cannot be displayed in Kodi (for https://github.com/xbmc/xbmc/pull/22333)

So far the only public samples that didn't work are those provided by the dash industry forum (e.g: https://livesim.dashif.org/dash/vod/testpic_2s/cea608.mpd) but they are completely broken, see:

https://github.com/Dash-Industry-Forum/dash-live-source-simulator/issues/99#issuecomment-1374546849 https://github.com/Dash-Industry-Forum/dash-live-source-simulator/issues/115

Maybe we can give them a go later on if those major issues are fixed