search

xbmc / inputstream.rtmp

RTMP input stream add-on for Kodi
GNU General Public License v2.0
15 stars 26 forks source link

Include all ffmpeg parameters ? #5

Closed hdgdl closed 7 years ago

hdgdl commented 8 years ago

As far as i can tell not all parameters available in ffmpeg/rtmpdump are included. Will the missing ones, like app or conn (For amf stuff) or token be added later on ?

Reference: https://rtmpdump.mplayerhq.hu/rtmpdump.1.html

The current windows ffmpeg implementation in kodi is missing parameters too https://github.com/xbmc/xbmc/pull/10015

Thanks in advance

notspiff commented 8 years ago

i ported the existing code. patches welcome for anything missing, i have no way to test so better somebody who do adds it.

  1. sep. 2016 11.55 p.m. skrev "hdgdl" notifications@github.com:

As far as i can tell not all parameters available in ffmpeg/rtmpdump are included. Will the missing ones, like app or conn (For amf stuff) or token be added later on ?

Reference: https://rtmpdump.mplayerhq.hu/rtmpdump.1.html

The current windows ffmpeg implementation in kodi is missing parameters too xbmc/xbmc#10015 https://github.com/xbmc/xbmc/pull/10015

Thanks in advance

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/notspiff/inputstream.rtmp/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AFktYPk9kGkPnvruYO6RLWnPh7_6-hLpks5qrbNegaJpZM4KAB2A .

notspiff commented 8 years ago

also do note that the list given in the code is there for legacy reasons. you should be allowed to pass all options supported by librtmp in the format expected by librtmp (evil space separated name=val after the actual url).

  1. sep. 2016 11.58 p.m. skrev "Arne Morten Kvarving" cptspiff@gmail.com:

i ported the existing code. patches welcome for anything missing, i have no way to test so better somebody who do adds it.

  1. sep. 2016 11.55 p.m. skrev "hdgdl" notifications@github.com:

As far as i can tell not all parameters available in ffmpeg/rtmpdump are included. Will the missing ones, like app or conn (For amf stuff) or token be added later on ?

Reference: https://rtmpdump.mplayerhq.hu/rtmpdump.1.html

The current windows ffmpeg implementation in kodi is missing parameters too xbmc/xbmc#10015 https://github.com/xbmc/xbmc/pull/10015

Thanks in advance

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/notspiff/inputstream.rtmp/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AFktYPk9kGkPnvruYO6RLWnPh7_6-hLpks5qrbNegaJpZM4KAB2A .

hdgdl commented 8 years ago

Thanks for the reply

On windows it wont recognize app or conn Additionaly if the rtmp url looks like "rtmp://blabla:1935/Path/Blabla" kodi requests only "/path" for app not "/Path/Blabla"

Will test again with linux/libreelec an report back

worstperson commented 7 years ago

From an initial look, the problem might be that RTMP_SetOpt() only gets called for options that exist in the options list. Will have a closer look when I get off of work.

worstperson commented 7 years ago

I know it's a bit late, but it ended up being my setup that was wrong not the inputstream code. My use case only uses multiple 'conn' parameters, I did not test for the 'app' issue mentioned by hdgdl.

notspiff commented 7 years ago

Aight.