search

xbmc / inputstream.rtmp

RTMP input stream add-on for Kodi
GNU General Public License v2.0
15 stars 26 forks source link

Fix struct initializations #55

Closed svenfoo closed 4 years ago

svenfoo commented 4 years ago

The INPUTSTREAM_IDS and INPUTSTREAM_INFO structs are defined as C structs, initializing by constructor may leave struct members uninitialized.

See the discussion in https://github.com/xbmc/xbmc/pull/17233 for reasons why this can not easily be fixed in the base class.

Fixes https://github.com/xbmc/inputstream.rtmp/issues/27

svenfoo commented 4 years ago

The failing AppVeyor build does not seem related to my changes, I assume that the build would also fail in the Leia branch.

I have created this pull request against the default branch Leia. Should it have been created against master instead? Just let me know, I'll rebase the changes then.

phunkyfish commented 4 years ago

Yes, @svenfoo. You should get the changes merged against Matrix first. After that Leia.

Also the fix version number should be incremented. So to 2.0.7

phunkyfish commented 4 years ago

Sorry, I stand corrected there is no Matrix branch. @AlwinEsch should there be a matrix branch?

It should be this addon only uses the Leia branch?

AlwinEsch commented 4 years ago

The API for VFS on Matrix and Leia are the same and they can stay on Leia and also makes sense to have the fix there.

But after them is in I can create also a Matrix branch to prevent future problems if the API becomes changed and is then more understandable as since it is already confusing to use a Leia branch together with Matrix on the Kodi.

phunkyfish commented 4 years ago

Thanks @AlwinEsch. And for the errors with AppVeyor what should be done?

@svenfoo, you still need to update the version in the addon xml.

phunkyfish commented 4 years ago

This all looks good now. We just need to verify what's up with appveyor before approve/merge.

@AlwinEsch please advise?

phunkyfish commented 4 years ago

Thanks very much for the contribution. I also made a release for the new version.