search

xbmc / inputstream.rtmp

RTMP input stream add-on for Kodi
GNU General Public License v2.0
15 stars 26 forks source link

[cleanup] use default initializers for member variables #56

Closed svenfoo closed 4 years ago

svenfoo commented 4 years ago

Just a minor cleanup. Mainly opened this pull request to check if the AppVeyor build is broken here as well or just on #55

AlwinEsch commented 4 years ago

The AppVeyor Problem on Leia should be fixed with them https://github.com/xbmc/xbmc/pull/17276.

Good cleanup :smile:

phunkyfish commented 4 years ago

@svenfoo do you want to combine the two PRs yourself or merge them separately?

svenfoo commented 4 years ago

@svenfoo do you want to combine the two PRs yourself or merge them separately?

I'm usually advocating for many small commits and since the changes are mostly unrelated I would prefer to see them merged separately.

phunkyfish commented 4 years ago

Small commits for sure. But PR wise that does not matter really, it just means a rebase after the first one is merged. All the commits in one PR avoids that.

Up to you.