search

xbmc / inputstream.rtmp

RTMP input stream add-on for Kodi
GNU General Public License v2.0
15 stars 26 forks source link

fix cross compiling on android and linux #8

Closed wsnipex closed 8 years ago

wsnipex commented 8 years ago

fixes https://github.com/notspiff/inputstream.rtmp/issues/7

openssl and librtmp were never cross compiled, kudos to the homegrown pile of bull they might call a build system

compile tested on linux native, android, arm-linux-32 cross

@fetzerch ping in case you have time to test OSX/IOS

notspiff commented 8 years ago

thanks. seems my cmakification of the bullshit i found in tools/depends went a bit too fast. shall i hold for that test ? (note: not saying the depends stuff is bullshit, just that's where i found the bullshit we have to suffer to have this work).

wsnipex commented 8 years ago

I'm not in a hurry, but as we all know testing is much easier once its merged.

notspiff commented 8 years ago

sure, can't be worse if it doesn't work at all currently.

fetzerch commented 8 years ago

Nice :). Will test tonight/tomorrow. Could you kick off a jenkins build? I've seen strange cases where locally it worked but on osx it used the system wide openssl.

Btw: Can we move this into https://github.com/xbmc/xbmc/tree/master/project/cmake/addons/depends/common it's also used by game.moonlight and imo it doens't make much sense to copy it around (considering its complexity). @garbear: fyi

notspiff commented 8 years ago

not my call but i would somewhat object ^^. it breaks with the idea of add-ons shipping their own dependencies, and will tie the add-on closer to particular kodi versions than what was (originally) desired. this does indeed mandate some duplication, but it's better than the alternative in my opinion. of course depends based builds are somewhat tightly coupled already (static links break that coupling again somewhat).

wsnipex commented 8 years ago

agree with spiff, we don't want to uselessly shove this down the throat of every addon that doesn't need it. Addons that need openssl, can simply copy it from here.

wsnipex commented 8 years ago

jenkins build triggered: http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-All/1704/

wsnipex commented 8 years ago

oh man, whats going on here:

make[6]: Entering directory '/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/openssl/src/openssl' make[6]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. created directory ../../../../../build' created directory../../../../../build/install' created directory ../../../../../build/install/home' created directory../../../../../build/install/home/jenkins' created directory ../../../../../build/install/home/jenkins/workspace' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/bin' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/lib' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/lib/engines' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/lib/pkgconfig' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/misc' created directory ../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/certs' created directory../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/private' making install in crypto... make[7]: Entering directory '/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/openssl/src/openssl/crypto' cp: cannot create regular file '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/crypto.h': No such file or directory chmod: cannot access '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/crypto.h': No such file or directory cp: cannot create regular file '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/opensslv.h': No such file or directory chmod: cannot access '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/opensslv.h': No such file or directory cp: cannot create regular file '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/opensslconf.h': No such file or directory chmod: cannot access '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/opensslconf.h': No such file or directory cp: cannot create regular file '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/ebcdic.h': No such file or directory chmod: cannot access '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/ebcdic.h': No such file or directory cp: cannot create regular file '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/symhacks.h': No such file or directory chmod: cannot access '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/symhacks.h': No such file or directory cp: cannot create regular file '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/ossl_typ.h': No such file or directory chmod: cannot access '../../../../../build/install/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/depends/include/openssl/ossl_typ.h': No such file or directory Makefile:117: recipe for target 'install' failed make[7]: Leaving directory '/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/openssl/src/openssl/crypto' make[7]: * [install] Error 1 Makefile:536: recipe for target 'install_sw' failed make[6]: Leaving directory '/home/jenkins/workspace/Android-ARM64-v8a/tools/depends/target/binary-addons/aarch64-linux-android-android-21/build/openssl/src/openssl' make[6]: * [install_sw] Error 1

fetzerch commented 8 years ago

Since @wsnipex is anyways the only one that can (or does) fix this kind of issues, do what you prefer. I'll see if i find time to formulate my concerns in a forum thread nonetheless. There must be better solutions than copying (and wasting time because it was overlooked that openssl was already used in an addon).

wsnipex commented 8 years ago

We could prepare a template/include file for a few often used dependencies. But I'd rather not add a default dependency in core, since there are currently only 2 addons I know of that need openssl.