search

xbmc / metadata.themoviedb.org.python

Other
44 stars 41 forks source link

Automatic addon submission #102

Open razzeee opened 2 years ago

razzeee commented 2 years ago

I see that there have been pipelines https://github.com/xbmc/metadata.themoviedb.org.python/actions/workflows/kodi-addon-submitter.yml but do they work? Do you want help?

There has been a attempt at upstreaming by hand, but automatic would be nicer.

https://github.com/xbmc/repo-scrapers/pull/308

rmrector commented 2 years ago

Automatic would be great. The closest I've come is running that github action on my fork. Something didn't want to work right when it was attached to the xbmc upstream, but it's been awhile so I don't remember the details.

Ideally it would be automatic from a PR, not a tag - submit an update when a version number change in addon.xml is merged.

razzeee commented 2 years ago

The automatic I have will need you to prepare the update in main and then create a tag

razzeee commented 2 years ago

Looking at the pipeline again, it should work fine. So we should try to use it again and maybe check the logs, if it fails.

The only difference to my working example is, that my implementation looks for a tag named v* and yours for number.number.number

rmrector commented 2 years ago

The action uses two secrets EMAIL and GH_TOKEN. Are those available and set up for this repo in the xbmc organization?

Because this scraper is "owned" by the team, both of these values need to be for Team Kodi or the XBMC organization, not for me or any one person - no one person should be responsible for and willing to do this correctly.

razzeee commented 2 years ago

I wasn't aware, that organization can have secrets, but your right, that's the better approach.

pkscout commented 2 years ago

I mentioned this is the PR for this for the TV show scraper, but I'll repeat here. I'm fine moving to something like this for easier submissions to the repo for Team Kodi add-ons. I'd just need a little help on the git side with the tags. That's not something I've done from the git CLI client. I've tagged things as releases using the GitHub web UI, but I don't know if that would accomplish the same thing.

razzeee commented 2 years ago

No, please don't use the release page after the change. It will be populated automatically, after creating the tag. I don't think github has a nice web frontend for it.

rmrector commented 2 years ago

This release submission was created with the same janky action as most other version updates. Are you offering to help make that better? Be careful, the addon submitter uses a "fork" of xbmc/repo-scrapers, and who knows what might blow up if that fork ends up as ... xbmc/repo-scrapers.

To be clear, you ignored the automated process that has always been here and merged a random GitHub user's changes, that were not yet merged upstream, into the official add-on repo. For a default add-on bundled with Kodi. This whole process needs drastic change, the action has nothing to do with it.