Closed apo86 closed 2 years ago
Same issue here, the variable search_results
isn't set anymore.
Seems to have been introduced in commit: ab240c98db18a06ba0fc24bbc192ab80ac848e13
.
Possible Fix in file python\scraper.py
:
scraper = get_tmdb_scraper(settings)
search_results = None
if year is not None:
search_results = scraper.search(title, year)
if not search_results:
search_results = scraper.search(title,str(int(year)-1))
if not search_results:
search_results = scraper.search(title,str(int(year)+1))
if not search_results:
search_results = scraper.search(title)
found it. Fix incoming.
Edit: Fix pushed in version 1.5.1.
When will 1.5.1 end up in the matrix repo?
I see the matrix version has a different python dependency: https://mirrors.kodi.tv/addons/matrix/metadata.themoviedb.org.python/
Is there a branch maintained somewhere for this matrix version?
@jeevcat
It has not been merged yet... https://github.com/xbmc/repo-scrapers/pull/319 It just needs a double check before the merge button is pushed. Should happen as soon as others wake up for the day :)
Ups, I just opened it as a bug under Kodi. I also logged that issue. Here is the log - as I think there might be a second issue: search language is always en-US
regardless what you configured in the module (see at the end of he log marked bold):
2021-10-20 11:06:20.380 T:1363 INFO
2021-10-20 11:06:20.911 T:1363 WARNING
Ups, I just opened it as a bug under Kodi. I also logged that issue. Here is the log - as I think there might be a second issue: search language is always
en-US
regardless what you configured in the module (see at the end of he log marked bold):
Yeah, you're right. Didn't even notice that. Looks like TMDB is quite tolerant when searching with the wrong language. Or rather it just doesn't care. From what I tested the language parameter in the search query didn't affect the order and number of search result at all, only the contents like localized overview or title. But those details are fetched by the scraper in a second query using the old language setting anyways. So to be honest I don't know what the new search_lanugage parameter even does.
]edit] Ohhh, of course. It affects the is_best() sorting because of the localized titles that are returned in the search query. Okay, then that makes sense. And that's also what's broken now due to the search language always being en-US.
also I can not set the Italian language scrapers, this log file maybe can help you understand I am not an expert
2021-10-20 19:00:49.375 T:9998 INFO
Pretty sure #101 is responsible for this.