search

xbmc / metadata.themoviedb.org.python

Other
44 stars 40 forks source link

fix: IMDB rating #140

Closed rmrector closed 2 years ago

rmrector commented 2 years ago

Better arrange parsers, rearrange test input to separate files. Adjust api_utils import to be testable, enable IMDB tests always. Add 1 end-to-end test for IMDB, not run regularly

KarellenX commented 2 years ago

@rmrector I tried downloading the zip file from the Master branch to test this now that it has been merged. The addon.xml is still using python version 2.26 so it won't install in Kodi v19.

rmrector commented 2 years ago

You should just have to change the version in addon.xml.

The release process makes the necessary changes for both Kodi versions.

KarellenX commented 2 years ago

Thanks @rmrector

I tried scraping a number of movies, English and French. Some as follows...

Standard movie... Avengers Endgame - No problem

Movie with no IMDB link at TMDB.... https://www.themoviedb.org/movie/847242-explore-a-soviet-dystopia No problem

Movie with no rating at IMDB... https://www.imdb.com/title/tt8885300/?ref_=nv_sr_srsg_0 Error on line 2263... https://paste.kodi.tv/irazowucap.kodi

rmrector commented 2 years ago

Try #142