search

xbmc / metadata.themoviedb.org.python

Other
44 stars 40 forks source link

IMDB fix the fix #142

Closed rmrector closed 2 years ago

rmrector commented 2 years ago

don't try to convert to float, doesn't parse IMDB pages pre-2021.

KarellenX commented 2 years ago

This fix seems to fix the error when scraping movies that have no ratings at IMDB.

https://www.imdb.com/title/tt8885300/?ref_=nv_sr_srsg_0 scraped ok.

Thanks :)

rmrector commented 2 years ago

Thanks for testing.

KarellenX commented 2 years ago

Also, what is the trick to downloading a zip file for a single PR like this? I simply copied the change to my local file. Works ok for one line changes, but not so good for large changes. Is there an easier way?

rmrector commented 2 years ago

Click the "rmrector:imdb-fix-2022-fix" link at the top of this page takes you to the branch, which then has the same "Download as Zip" option as the master branch.

KarellenX commented 2 years ago

ah, simple. Thanks :)