xbmc / metadata.themoviedb.org.python

Other
44 stars 40 forks source link

Folder name not used for search? #194

Closed LukeV1 closed 1 year ago

LukeV1 commented 1 year ago

Hello again..

I found another kind of issue in the log files that I don't really understand.

It seems to me that the scaper is making things a bit too easy for himself ;)

I added an examle here: log.txt The file structure is here: grafik

When searching the folder name "Die Tribute von Panem (2) - Catching fire" TMDB succeeds. But when searching only the file name "tribute catching fire disc1" it fails.


I think this problem applies to many other cases as well, i.e. when the file in the folder is just named "Disc1.iso" or something...

KarellenX commented 1 year ago

@LukeV1

Your folder name is... smb://ZOTAC/FILME/eigene-Filme/Die Tribute von Panem (2) - Catching fire/

But the search string is TRIBUTE CATCHING FIRE DISC1

Two problems...

  1. The folder name is correct but the file naming is wrong as there is no such movie as TRIBUTE CATCHING FIRE DISC1.
  2. You most likely have not enabled the setting Movies are in separate folders that match the movie title in the Source settings, which forces the use of the folder name for the search string.
LukeV1 commented 1 year ago

First of all: Thanks for your quick answer!

You slightly misunderstood me. By folder name I didn't mean the path, just the folder name that contains the actual files (-> the last subfolder).

So the scraper just took the filename itself as you pointed out (TRIBUTE CATCHING FIRE DISC1) but after being unsuccessful it didn't try the parent folder name (The Hunger Games (2) - Catching Fire), as it does on regular DVD folders.

Your 2. point is probably right, at least I can't remember it - I'll check.

LukeV1 commented 1 year ago

I have checked it. Movies are in separate folders that match the movie title was not enabled. And you were right, this solved quite a lot of issues I encountered. It also created some new ones that I'm currently investigating. Thanks for that hint!

Still, I think it would be nice if the parser tried the movie file's parent folder name if nothing was found to search again for it. But this is now definitely a feature request and not a bug.

KarellenX commented 1 year ago

Still, I think it would be nice if the parser tried the movie file's parent folder name if nothing was found to search again for it.

Can't. Not everybody uses movie folders. Some just add the video file directly into the Source, so there are hundreds or thousands of movies in a single folder. If we do it your way, then all unscrapable items will be trying to match the source folder, usually named "Movies" - lots of duplicates, lots of wrong movies, which leads to a very big mess that will become too difficult to find and fix the affected movies.

Great that the setting fixed the original problem. What new problem do you have?

LukeV1 commented 1 year ago

Can't. Not everybody uses movie folders. Some just add the video file directly into the Source, so there are hundreds or thousands of movies in a single folder.

Ah! Thats right. So it has to be the way it is.

My new problem is how MakeMKV saves movies. Take this example: grafik

Besides the main movie some - sometimes many - additional files are stored (with trailers, outtakes, extras,... - all the other stuff accessible from the movie's main menu). Now I get an entry for each file in that folder, all of which are recognized as the movie. My Kodi library is now crammed with several hundred duplicate entries containing all the extras, trailers,... Some movies now appear 20 times in the library view. Quite a mess.

KarellenX commented 1 year ago

https://kodi.wiki/view/Add-on:Extras

LukeV1 commented 1 year ago

Wow. Thanks!

Isn't there any official website that explains everything about movie scraping with KODI? Am I just too stupid to find it or does everyone really have to find out this information for themselves?

As I realize now most of my "issues" were simply due to ignorance...

KarellenX commented 1 year ago

Isn't there any official website that explains everything about movie scraping with KODI?

Yes, visit our wiki... https://kodi.wiki/view/Main_Page

In particular, the video library part... https://kodi.wiki/view/Video_library

In the search box, type in a word like "Extras" or "Trailers" and you should get a hit. I think most common terms are covered in the wiki, but if some are missing, or you have ideas to improve, then post suggestions on the Kodi forum

LukeV1 commented 1 year ago

Oh dear. I was too stupid. This is exactly the gold mine I've been looking for.

I'm sorry for having bothered you with all these stupid questions..

Thanks again!