search

xbmc / metadata.themoviedb.org.python

Other
46 stars 41 forks source link

remove external module dependencies #55

Closed pkscout closed 4 years ago

pkscout commented 4 years ago

This is the bundle of code changes to remove the dependencies on tmdbsimple, trakt, and requests modules. All the external calls are now handled by urllib2 (Python 2) or urllib (Python 3). I tried to minimize the changes to the core of the code, so tmdbapi.py mostly mimics the previous API calls and the changes to traktratings.py, imdbratings.py, and fanarttv.py are all internal. There are two sets of changes to tmdb.py.

  1. all the error handling for URL requests is now handled in api_utils or tmdbapi, so the logic to check for raised errors was updated.
  2. With direct API calls images can now be returned with the primary query with different language requirements (images that match the language in the settings, English, or NULL are returned). That means the images are now loaded with the primary movie dict instead of the fallback one.
razzeee commented 4 years ago

Yes, I think that's sensible

On Tue, Oct 6, 2020, 00:47 Kyle Johnson notifications@github.com wrote:

@pkscout commented on this pull request.

In changelog.txt https://github.com/xbmc/metadata.themoviedb.org.python/pull/55#discussion_r499912906 :

@@ -1,3 +1,8 @@ +v1.2.2 (2020-10-04) +- Fix: removed dependencies on requests, tmdbsimple, and trakt modules

I was trying to keep the changelog to the same format, and there were only Features and Fixes. Features felt like user facing things, so I used Fixes. Could we just list it as Change?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/xbmc/metadata.themoviedb.org.python/pull/55#discussion_r499912906, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNLEZC7OAHPCQ4WA63FH6DSJJEH3ANCNFSM4SD5CBWQ .

pkscout commented 4 years ago

3a42bdfff042c288c2c7004aa2d4e9cd690c8c97 updates the change log and version number. I also added the change log info to the news section of addon.xml