xbmc / metadata.themoviedb.org.python

Other
46 stars 42 forks source link

Do not traverse inside .ISO files and ignore VIDEO_TS/*.VOB files inside .ISO #72

Closed timkgh closed 3 years ago

timkgh commented 3 years ago

It appears that Kodi 19 mounts .ISO files automatically and the scarper traverses inside .ISO files and finds a bunch of .VOB files that it tries to look up at TMDB. This is very slow and it never has a chance of doing anything useful. There can be many .VOB files inside an .ISO, multiply that with a bunch of .ISO files and every library update can take a long time.

Example of a failed lookup: 'archive://nfs%3a%2f%2f192.168....%2fnas%2f...%20(1989).ISO/VIDEO_TS/VTS_14_4.VOB'

2021-03-27 11:30:59.466 T:13782    INFO <general>: [metadata.themoviedb.org.python]: Find movie with title 'VTS_14_4' from year 'None'
2021-03-27 11:30:59.467 T:13782   DEBUG <general>: using title of vts_14_4 to find movie
2021-03-27 11:30:59.467 T:13782   DEBUG <general>: Calling URL "https://api.themoviedb.org/3/search/movie?api_key=...&language=en-US&query=vts_14_4"
2021-03-27 11:30:59.671 T:13782   DEBUG <CAddonSettings[metadata.themoviedb.org.python]>: trying to load setting definitions from old format...
2021-03-27 11:30:59.674 T:13782    INFO <general>: CPythonInvoker(2, /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/metadata.themoviedb.org.python/python/scraper.py): script successfully run
2021-03-27 11:30:59.674 T:13759 WARNING <general>: No information found for item 'archive://nfs%3a%2f%2f192.168....%2fnas%2f...%20(1989).ISO/VIDEO_TS/VTS_14_4.VOB', it won't be added to the library.

This is a single .ISO file on the filesystem but something in Kodi mounts it as an archive.

Instead, for .ISO files it should try to look up the title based on the .ISO file name and stop. It should recognize patterns such as archive://*.ISO/VIDEO_TS/*.VOB and ignore them by default, these never lead to anything useful.

rmrector commented 3 years ago

Not an issue with the scraper.

https://github.com/xbmc/vfs.libarchive/issues/49

KarellenX commented 3 years ago

https://github.com/xbmc/vfs.libarchive/pull/53