search

xbmc / metadata.themoviedb.org.python

Other
44 stars 41 forks source link

Artwork from TMDb not scraping, probably due to link in description. #80

Closed t0mtee closed 2 years ago

t0mtee commented 3 years ago

This has been fixed on this scraper but not this one. Only artwork from fanart.tv is shown.

rmrector commented 3 years ago

This Python scraper was not affected by that, you are likely seeing a combination of two behaviors this scraper has always had - there is a strict limit of 10 images for each art type, and fanart.tv artwork is listed first.

If that doesn't match your observations, I'll need some specific example movies to investigate further.

t0mtee commented 3 years ago

Is it possible to change the limit?

t0mtee commented 3 years ago

Hey @rmrector sorry for the ping, but can I get an answer to my question please?

rmrector commented 3 years ago

The limit is in place due to a bug in Kodi. The bug in Kodi can be fixed by someone willing to put in the effort.

https://github.com/xbmc/xbmc/issues/15768

KarellenX commented 2 years ago

Can we close this @rmrector ? It's not a bug, but intended behaviour.

t0mtee commented 2 years ago

Sorry for reviving a dead topic, but why does this bug only affect this addon and not the other TMDB scraper?

KarellenX commented 2 years ago

Which bug? Can you explain what you are expecting, and what happens instead? You are referring to something from a year ago and, if it was a problem, the forum would have been flooded with complaints. Thanks.

t0mtee commented 2 years ago

The limit is in place due to a bug in Kodi. The bug in Kodi can be fixed by someone willing to put in the effort.

xbmc/xbmc#15768

I'm refering to this bug, which apparently limits the amount of artwork the plugin can scrape to 10. I've only seen it affect this addon however

KarellenX commented 2 years ago

oh, that is not a bug. That is intended behaviour. How many artwork do you want? Why would you potentially want 50 or 100 fanart links?

This is not the only scraper that has the limitation. TMDB TV Shows, TV Maze and this scraper have it. The older XML scrapers do not have it, and they are the ones that cause problems for users using MySQL/MariaDB setups.

KarellenX commented 2 years ago

I haven't tried, but I guess you could modify this line on your own setup and test if it works... https://github.com/xbmc/metadata.themoviedb.org.python/blob/master/python/scraper.py#L82-L85 Of course, each time the scraper is updated, your edit will be reset.