search

xbmc / metadata.tvshows.themoviedb.org.python

themoviedb.org TV Show scraper in Python for Kodi 18 (Leia) or later.
GNU General Public License v3.0
20 stars 26 forks source link

Separation of primary language definition for details and images #115

Closed burekas7 closed 1 year ago

burekas7 commented 1 year ago

metadata.tvshows.themoviedb.org.python (Based on version 1.6.5)

Separation of primary language definition for details and images.

With this feature, user can get Tv Show info in one language and images in another language.

Tested on Kodi Nexus 20.1 (Windows)

pkscout commented 1 year ago

 I don't like the idea of someone, by default, having to change their language in two places and make sure they stay in sync.  I think what you should do is add a toggle that says something like "use different language for images" that, when activated, will show the additional setting.  If you don't turn that on, the "main" language setting will be used for both.  That way the default behavior remains the same.  With your PR as is everyone's image language would change to English (the default) unless they go set it again.  With my suggestion, the behavior won't change unless you make an intentional choice to change it.

I'm pretty sure you can update the logic in settings.py so that LANG_DETAILS and LANG_IMAGES get set the same if that new toggle is NOT activated (which should be the default) and to the different settings if the toggle is activated.

burekas7 commented 1 year ago

@pkscout Got it. I will update the settings and then I will update the PR as well.

burekas7 commented 1 year ago

@pkscout I have updated the PR according to your suggestion. By default the main current langauge setting will be the same for images when it's false. When it's true, it will set the images langauge according to the new setting.