search

xbmc / metadata.tvshows.themoviedb.org.python

themoviedb.org TV Show scraper in Python for Kodi 18 (Leia) or later.
GNU General Public License v3.0
20 stars 26 forks source link

Added trailer to TV Shows #29

Closed tielis closed 3 years ago

tielis commented 3 years ago

Add TV Show trailer

pkscout commented 3 years ago

As with the other PR, if this is accepted at all (and I'm still pondering), I would want a separate PR for the Leia branch as well.

KarellenX commented 3 years ago

I know that Trailers are a missing feature for TV Shows. Local trailers are not scanned and they need to be forced in a clunky way.

There has never been a tv show scraper with trailer features, so I cannot confirm whether Kodi will treat this correctly.

Have you tested this in Kodi @tielis ?

Thanks for the contributions :)

pkscout commented 3 years ago

Thanks for your thoughts @KarellenX. I do like the idea having it as an optional setting in the scraper.

KarellenX commented 3 years ago

Yes, I prefer the optional setting also.

There used to be a bug where if you had local trailers but had the Trailer setting in the scraper enabled, the local trailer would be ignored in preference for the online link which is contrary to how Kodi treats all other local information. For this reason I used to always disable the trailer setting in the scraper.

But I cannot seem to replicate that behaviour in v19 anymore, nor could I find any fix related to this issue. Probably safer to have the setting in case the bug reappears.

KarellenX commented 3 years ago

Just had a quick search as I recalled discussing trailers for tv shows once before with AkariDN.

https://github.com/xbmc/xbmc/pull/13566#issuecomment-495976133

tielis commented 3 years ago

@KarellenX I have been using kodi with this change for a while, but I haven't tested it with local Trailers, so I don't know how it will behave. I'll be implementing it as optimal setting then.

tielis commented 3 years ago

Do we really need to put Trailer option default off ? People are so used to not have trailers for TV Shows that no one will notice we have it available now. I would vote to leave it as default 'on' and if bugs start to come up, we change to off. Trailers for movies are default on, Tv shows should be the same.

As soon you give a thumbs up, I will PR for Leia too.

pkscout commented 3 years ago

Other than the strings comment, this looks good. With that last change, I'm willing to merge this and then do the same when you get the Leia one done. Thanks for your contribution.