search

xbmc / metadata.tvshows.themoviedb.org.python

themoviedb.org TV Show scraper in Python for Kodi 18 (Leia) or later.
GNU General Public License v3.0
20 stars 26 forks source link

UniqueID #6

Closed KarellenX closed 4 years ago

KarellenX commented 4 years ago

Could you also add scraping of IMDB ID and TVDB ID to be used as UniqueID's for both TV Show and Episodes.

These ID's, especially the IMDB ID, can be used by other add-ons.

FYI. While testing be aware of this issue, which Montellese has confirmed, or it can drive you a bit mad as it did me ;)... https://github.com/xbmc/xbmc/issues/17444

uniqueid

pkscout commented 4 years ago

added with 058ad7b790a53a7fdda34574182e83d616ef994f. Because Freebase and TVRage are defunct, the scraper only adds tmdb, tvdb, and imdb ids.

KarellenX commented 4 years ago

All working well. Strangely, I scraped three complete shows and I did not encounter the bug I linked above.

Thanks!!

KarellenX commented 4 years ago

Just noticed an issue with UniqueID's

If the UniqueID's for IMDB and TVDB are empty at TheMovieDB (which happens often) then the scraper is forcing a non-UniqueID as shown in the example below.

<uniqueid type="imdb">None</uniqueid>
<uniqueid type="tmdb" default="true">1778196</uniqueid>
<uniqueid type="tvdb">None</uniqueid>

If a uniqueid is not available, then (in the above example) imdb and tvdb entries should not be made.

uniqueid

pkscout commented 4 years ago

fixed with 601c7ebadece107ac9891440a04d00c74aebd24e

KarellenX commented 4 years ago

Bug fixed.