search

xbmc / peripheral.joystick

Kodi joystick support (drivers and button maps)
GNU General Public License v2.0
24 stars 46 forks source link

Add buttonmap for DualShock4 connecting to macOS via BT. #189

Closed nickolay closed 3 years ago

nickolay commented 3 years ago

Tested using DualShock 4 (2nd gen) controller connected via bluetooth to a Macbook running macOS 11.2.3.

It advertises itself as "DUALSHOCK 4 Wireless Controller", axes: 6, hats: 0, buttons: 14, not as "Wireless Controller" specified in the existing button map.

So even though the vid/pid and the rest are the same, the existing button map is not used.

As Joystick families (#32) do not seem to be fully implemented (adding a new entry to the joystickfamilies.xml didn't have an effect and I don't see where it's used in the code), I solve this by duplicating the existing button map with a different name.

garbear commented 3 years ago

Thanks! Until joystick families are implemented, the intention is to have a new XML file for every driver name, because XML is relatively cheap for now. There are many improvements we could make to further the vision of intelligently mapping unseen controllers. Joystick families sprung up entirely as a way to re-use any data we could from the old buttonmaps before the new joystick system in v17.