So I figure we'll enable it for v21 and watch out for any crashes. If all goes well we can ship the Guide button in v21. If we hear more reports of crashes, we can look into other options.
Tested on latest master. Guide button works, but only after disabling the following setting:
Start -> Settings -> Gaming -> Xbox Game Bar
Disable "Open Xbox Game Bar using this button on a controller: X"
After that, the Guide button works in Kodi.
However, if Steam is open in the background, then it will be focused. Steam must be exited to not interfere with Kodi. There should be a way to fix this in Steam, however.
Description
This PR re-enables the Guide button on Windows 8/10. It was originally disabled in early 2017 in https://github.com/xbmc/peripheral.joystick/pull/79 due to the following crash reported by some users:
Now, we have some feature requests for the Guide button to return: https://forum.kodi.tv/showthread.php?tid=339917
So I figure we'll enable it for v21 and watch out for any crashes. If all goes well we can ship the Guide button in v21. If we hear more reports of crashes, we can look into other options.
How has this been tested?
Included in latest 20.2 test builds: https://github.com/garbear/xbmc/releases
Tested on latest master. Guide button works, but only after disabling the following setting:
Start -> Settings -> Gaming -> Xbox Game Bar
Disable "Open Xbox Game Bar using this button on a controller: X"
After that, the Guide button works in Kodi.
However, if Steam is open in the background, then it will be focused. Steam must be exited to not interfere with Kodi. There should be a way to fix this in Steam, however.