search

xbmc / repo-skins

Official source repository for Kodi skin add-ons
63 stars 49 forks source link

[Update] skin.apptv 1.6.0 #190

Closed wyrm65 closed 5 years ago

wyrm65 commented 5 years ago

Add-on details:

Description of changes:

Checklist:

Rechi commented 5 years ago

The correct forum address is https://forum.kodi.tv not forum.Kodi.org. Its wrong in CONTRIBUTING.md, README.md and addon.xml.

wyrm65 commented 5 years ago

Rechi,

Thank you, good spot. Obviously missed the memo on location change.

Fixed in pull 951a9695c8b54cbd68e343ce56f38d6f2b585b62

wyrm65 commented 5 years ago

Sorry guys can we please park this for the moment. A user has found a major problem where selecting a favourite from DialogFavourites.xml will crash Kodi. Trying to track down what issue is at the moment, will advise when is safe to push the button on this.

ronie commented 5 years ago

nothing wrong with your code, you just seem to trigger an add bug in kodi i think...

adding a WindowClose animation to the dialog fixes it for me. just don't ask me why ;-)

wyrm65 commented 5 years ago

Ronie, saved by you once again. Yep that resolved the issue. Can we please unpark this pull request and get it into repo before the user finds any more like this ;-) .

new pull request ea5287fcf73a2ca1d9a94af428f80d9c2ca96219 .

Thanks mate.

ronie commented 5 years ago

i wouldn't worry about the user too much mate. the only thing you have got to fear is my all seeing eye.. so here we go:

Label not defined: 161 xml/DialogVideoInfo.xml: line 108

Label not defined: 14061 xml/SettingsProfile.xml: line 105

Label not defined: 14061 xml/SettingsProfile.xml: line 177

Label not defined: 161 xml/script-script.extendedinfo-DialogVideoInfo.xml: line 67

Label not defined: 161 xml/DialogAddonInfo.xml: line 51

Label not defined: 31597 xml/Custom_HomeMenuItems.xml: line 713

Label not defined: 161 xml/DialogPVRInfo.xml: line 62

Label not defined: 161 xml/DialogMusicInfo.xml: line 81

Label not defined: 161 xml/DialogMusicInfo.xml: line 241

Label not defined: 161 xml/DialogMusicInfo.xml: line 355

Label not defined: 161 xml/View-General.xml: line 150

Label not defined: 161 xml/View-General.xml: line 373

Window ID not defined: 1101 xml/GameOSD.xml: line 9

Brackets do not match: false> xml/script-script.extendedinfo-DialogVideoInfo.xml: line 248

Brackets do not match: false> xml/script-script.extendedinfo-DialogVideoInfo.xml: line 251

Brackets do not match: false> xml/script-script.extendedinfo-DialogVideoInfo.xml: line 254

Brackets do not match: false> xml/script-script.extendedinfo-DialogVideoInfo.xml: line 257

Brackets do not match: String.IsEqual(Window(home).Property(SelectDialogType),videoinfomore) | String.IsEqual(Window(home).Property(SelectDialogType),musicinfomore | String.IsEqual(Window(home).Property(SelectDialogType),gamesettings) xml/Custom_DialogSelect.xml: line 211

Brackets do not match: control.hasfocus(10 xml/MyPVRGuide.xml: line 165

Brackets do not match: control.hasfocus(60 xml/MyPVRGuide.xml: line 167

Brackets do not match: window.isactive(script-cu-lrclyrics-main.xml xml/MusicVisualisation.xml: line 4

^ it's none of my business of course, but i couldn't help but notice you're a bit short on brackets.... just in case you might be interested, i do have some spare brackets laying around gathering dust. i've got a dozen square brackets (special price for you my friend) and some nice curly ones. the curly brackets are 20% off this week.

wyrm65 commented 5 years ago

Can I have three squares and a curly. Oh and a packet of full stops please.

I'm positive you are no longer using XBMC Skinning Tool v1.2.6 as did not find brackets when I checked with it. That and checking labels just causes it to crash.

Try pull 505882872d81f5f55e751ed348dd6356ce1e3a11 which includes all of your suggestions and a small fix for some log spam.

ronie commented 5 years ago

the Skinning Tool is old news. Kodi Devkit is currently the best bang for the buck.

i've added AppTV to the leia repo, thx! https://github.com/xbmc/repo-skins/commit/031e7c7832936f6174b06088f20b5639116305fc