xbmc / repo-skins

Official source repository for Kodi skin add-ons
67 stars 49 forks source link

[skin.confluence] v5.0.4 #441

Closed Hitcher closed 7 months ago

Hitcher commented 7 months ago

Add-on details:

Description of changes:

Checklist:

Additional information :

ronie commented 7 months ago

updated, thx! https://github.com/xbmc/repo-skins/commit/98f49d09595bc29544141f16a43c8e402009ab43

let's keep an eye on it if it makes it into the repo this time.

MikeSiLVO commented 7 months ago

Every time my skin was updated in repo it would've populated by now. Since it hasnt yet I assume there is either a new repo issue with adding skins or some other unknown related to confluence...

Only big changes I notice that could be a contributing factor is the 720p --> 1080p conversion but I am only guessing on that.

There is also a v in the version number for 4.8.3 in the addon.xml

Is that marking it higher than 5.0.3/4??

MikeSiLVO commented 7 months ago

@ronie @Hitcher Maybe bump nexus to 4.8.4 without the v and see if helps? Not sure if v4.8.3 existing would cause further issue since it seems versioning uses alphabetical order so that would be above anything else using just numeric.

Alternatively, if that is the issue, then making Omega v5.0.5 or something could also work.

ronie commented 7 months ago

yeah.. you could be right there. i hadn't noticed this v made it's way into the version number.

i'd rather prefer to get rid of it instead of continuing with version="vX.X.X" i'll check what our server admins think of it..