[skin.amber] v3.50.02 - Githubissues

xbmc / repo-skins

Official source repository for Kodi skin add-ons

65 stars 49 forks source link

Closed MikeSiLVO closed 3 months ago

MikeSiLVO commented 3 months ago

Updating Amber for Nexus. With bartolomesoriano's permission.

[x] My code follows the add-on rules and piracy stance of this project.
[x] I have read the CONTRIBUTING document
[x] Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
add-on development wiki page.
Kodi pydocs provide information about the Python API
PEP8 codingstyle which is considered best practice but not mandatory.
This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
Development questions can be asked in the add-on development section on the Kodi forum.

MikeSiLVO commented 3 months ago

I see the error but I do not see where the issue actually is. Any pointers would be appreciated since it looks like a zipped after the fact problem.

Thanks.

ronie commented 3 months ago

doesn't look related to your skin, so let's ignore it for now :)

came across a few things to check though:

Variable not defined: EpisodeTitleVar 1080i/View_502_RightList.xml: line 2035

Variable not defined: TitleColorVar 1080i/View_502_RightList.xml: line 2037

Variable not defined: InfoWallBottomLabel1Var 1080i/View_502_RightList.xml: line 2046

Variable not defined: ListAlbumVar 1080i/View_502_RightList.xml: line 2056

Variable not defined: TitleColorVar 1080i/View_502_RightList.xml: line 2084

Variable not defined: TitleColorVar 1080i/View_502_RightList.xml: line 2096

Variable not defined: InfoWallBottomLabel1Var 1080i/View_502_RightList.xml: line 2107

Variable not defined: InfoWallTextboxVar 1080i/View_502_RightList.xml: line 2116

MikeSiLVO commented 3 months ago

I thought I commented all of those out. I'll take a look when I get home 😄

I wasn't sure if Bart was in the middle of adapting the code to Amber or not so didn't want to just delete it.

ronie commented 3 months ago

ah that could be, my automated script might have missed that.

ronie commented 3 months ago

nope, they are still there.

MikeSiLVO commented 3 months ago

I can’t double check the PR files. GitHub mobile is crap lol

The entire include should be commented out

ronie commented 3 months ago

confirmed, must've been a brainfart.

MikeSiLVO commented 3 months ago

Thanks, ronie 😃