search

xbmc / skin.confluence

Other
52 stars 75 forks source link

Border Missing Around Add-on Shortcuts #272

Closed 42RoiDesRois42 closed 6 months ago

42RoiDesRois42 commented 6 months ago

May be my issue but can’t get around it. Apologize for creating issue if it is my problem alone.

My default page is videos but happens on movies, etc. Down arrow doesn’t immediately show/highlight the border around the add-on shortcuts so I don’t know what is highlighted. I do know the behavior so I’m able to press down once then right once or left twice to get to things but it’s an issue. Reinstalling local version of 4.8.0 resolves the issue.

Kodi 20.5, Confluence 4.8.4

Thanks.

Hitcher commented 6 months ago

Using the exact same setup (Kodi v20.5 & Confluence v4.8.4) they work for me:

screenshot00019

42RoiDesRois42 commented 6 months ago

Using the exact same setup (Kodi v20.5 & Confluence v4.8.4) they work for me:

screenshot00019

Thanks. Let me give it another try and see (could have been in between and I don’t know github well enough to check version releases; did check issues).

42RoiDesRois42 commented 6 months ago

Ok. I confirmed the behavior and what’s happening. Kodi starts, default is Videos (happens on Videos, Movies, TV shows but not Add-Ons).

Short Version To reproduce map 5 video shortcuts, then disable the addon mapped to the 1st (far left) shortcut.

Detailed version When I click down it highlights files. If I click down again nothing. Next down click highlights the Power.

Now if I click down to the line of shortcuts (only have 4 and second shows under Library; will come back to this), then click right the highlight shows up.

Now back to 4 shortcuts, etc. The 4.8.0 version defaulted to the addon shortcut that was directly under Add-ons regardless of having 4 or 5 shortcuts there. I believe what’s happened with the new version is that it is now defaulting to the shortcut on the far left instead of directly under Add-on or even Library. The issue here is that if there is a disabled addon (there is in my case) the new version still sees that as a shorcut since it was mapped and does not seem to account for that disabled addon like it used to.

Since the same shortcuts show up under Videos, Movies, and TV Shows, that’s why I have the same behavior on all three, whereas I don’t have a disabled program addon and those shortcuts work.

Hitcher commented 6 months ago

Try as I might I can't reproduce this issue.

https://github.com/xbmc/skin.confluence/assets/133808/d893326b-e8ee-470c-bd53-752ecc43002d

And I also can't see why Kodi would focus an item in a list when it was hidden.

42RoiDesRois42 commented 6 months ago

Thanks. Yeah, I was assuming the reset of the highlight to the left caused it but I definitely see that it’s not behaving the same for you. Going to look into it more over the weekend. Is there any place under the hood I should check or a db to verify, etc?

Hitcher commented 6 months ago

You could try enabling debugging in the addon.xml.

<extension point="xbmc.gui.skin" debugging="false" effectslowdown="1.0">

Change false to true.

This will then show you the current focused control.

screenshot00020

screenshot00021

screenshot00022

42RoiDesRois42 commented 6 months ago

Thank you. Much appreciated.

42RoiDesRois42 commented 6 months ago

I gave it a shot with the debugging on. The information did not change whether it was on the hidden shortcut (invisible) or when I moved it to the right (visible shortcut) where the border/highlighting did work. In any case, I just remapped the shortcuts, omitting the disabled add-on and have no issues.

Hitcher commented 5 months ago

What was the ID when you focused on the hidden item?

42RoiDesRois42 commented 5 months ago

What was the ID when you focused on the hidden item?

I don’t recall exactly at this point but I believe one of the numbers was 700 and that was the same on the blank shortcut and the 2nd (not disabled). It went up only when it was moved to the third from the left (including the blank/disabled shortcut).