xbmc / visualization.shadertoy

Shadertoy visualizer for Kodi
GNU General Public License v2.0
34 stars 41 forks source link

No bars in OSMC with kodi 19 #91

Open sylvaing26 opened 2 years ago

sylvaing26 commented 2 years ago

Hello, I've an issue with shadertoy in OSMC qith Kodi v19. When visualization is activated, for exemple with 2D Spectrum, I see only background. I've not animations on bars when music is played

(Sorry for my bad english...)

Thanks

sylvaing26 commented 2 years ago

Hi, I've solved the issue myself. Thanks to this post : https://discourse.osmc.tv/t/where-did-shadertoy-go/79424/12 I've compiled addon myself from source with changes. The issue is due to the GL_RED and GL_LUMINANCE detection.

This is my procedure with OSMC : sudo apt install git zip libgles2-mesa-dev build-essential git clone --branch Matrix https://github.com/xbmc/visualization.shadertoy.git git clone --branch Matrix https://github.com/xbmc/xbmc.git

Change to GLES : nano /home/osmc/visualization.shadertoy CMakeLists.txt Modify line 12 to if(1 == 0)

Force GL_LUMINANCE nano /home/osmc/visualization.shadertoy/src/main.cpp Comment lines 24 and 26 like this : `` //#ifndef GL_RED

define GL_RED GL_LUMINANCE

//#endif ``

Rename plugin to Shadertoy 2 to disable conflict : nano /home/osmc/visualization.shadertoy/visualization.shadertoy/addon.xml.in Modify lines 3 and 5 like this : id="visualization.shadertoy2" version="19.1.2" name="Shadertoy 2"

Compile addon : cd visualization.shadertoy && mkdir build && cd build cmake -DADDONS_TO_BUILD=visualization.shadertoy -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../../xbmc/kodi-build/addons -DPACKAGE_ZIP=1 ../../xbmc/cmake/addons make

Link the addon folder to osmc : ln -s ln -s /home/osmc/xbmc/kodi-build/addons/visualization.shadertoy /home/osmc/.kodi/addons/visualisation.shadertoy2

Restart raspberry and activate Shadertoy 2 module

ildar170975 commented 2 years ago

Not sure if it is related but Shadertoy stopped working in LibreELEC 10 too. Almost every preset does not show or shows just some static part of itself. RPi 2.

sylvaing26 commented 2 years ago

Yes it's related. The issue was fixed on last osmc update : https://discourse.osmc.tv/t/visualizations-not-working-in-19-3/91899 It's due to GLES 3. On RPI, it work only with GLES 2 I expect that Kodi's team also fix this issue... You can open an issue on OpenElec too, they Can also fix it on her distribution...

ghost commented 1 year ago

Amlogin, Android 6, Kodi 19.5, same issue, this patch working.

Hi, I've solved the issue myself. Thanks to this post : https://discourse.osmc.tv/t/where-did-shadertoy-go/79424/12 I've compiled addon myself from source with changes. The issue is due to the GL_RED and GL_LUMINANCE detection.

This is my procedure with OSMC : sudo apt install git zip libgles2-mesa-dev build-essential git clone --branch Matrix https://github.com/xbmc/visualization.shadertoy.git git clone --branch Matrix https://github.com/xbmc/xbmc.git

Change to GLES : nano /home/osmc/visualization.shadertoy CMakeLists.txt Modify line 12 to if(1 == 0)

Force GL_LUMINANCE nano /home/osmc/visualization.shadertoy/src/main.cpp Comment lines 24 and 26 like this : //#ifndef GL_RED #define GL_RED GL_LUMINANCE //#endif

Rename plugin to Shadertoy 2 to disable conflict : nano /home/osmc/visualization.shadertoy/visualization.shadertoy/addon.xml.in Modify lines 3 and 5 like this : id="visualization.shadertoy2" version="19.1.2" name="Shadertoy 2"

Compile addon : cd visualization.shadertoy && mkdir build && cd build cmake -DADDONS_TO_BUILD=visualization.shadertoy -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../../xbmc/kodi-build/addons -DPACKAGE_ZIP=1 ../../xbmc/cmake/addons make

Link the addon folder to osmc : ln -s ln -s /home/osmc/xbmc/kodi-build/addons/visualization.shadertoy /home/osmc/.kodi/addons/visualisation.shadertoy2

Restart raspberry and activate Shadertoy 2 module