xbmc / visualization.spectrum

Spectrum visualizer for Kodi
GNU General Public License v2.0
8 stars 23 forks source link

Cleanup, fix and improve code #25

Closed AlwinEsch closed 5 years ago

AlwinEsch commented 5 years ago

This changed makes a big cleanup (mostly rewrite), further are some render contents fixed.

Can this request be quickly checked on Mac OS X! There on waveform https://github.com/xbmc/visualization.waveform/pull/15 almost had a heart attack, where I brought it worked my Android test (probably had Kodi, somehow still the previous version?), When I started this here and tested on Android but it ran but Kodi was no longer possible to control (Skin overwritten throughout) !!! Then tested waveform and the same. Will now immediately bring a fix to "waveform" because otherwise a user could despair.

The use of glBufferData has brought this problems on Android/GLES. Without the use of them has it worked here under Linux, only with Mac I'm unsure.

Filled mode Before: Bildschirmfoto von 2019-03-23 00-46-54 Now (in the style it was also on GL2 before): Bildschirmfoto von 2019-03-23 00-53-30

Wireframe mode Before: Bildschirmfoto von 2019-03-23 00-47-19 Now: Bildschirmfoto von 2019-03-23 00-55-38

Points mode Before (was set with m_mode = GL_LINES; //no points on gles!): Bildschirmfoto von 2019-03-23 00-47-19 Now: Bildschirmfoto von 2019-03-22 21-51-34

About the points related to GLES 2.0-3.0 documentation is it supported, further has it worked on my Android.

The point size is now editable by user.

Also, I have the question how DirectX pixel size can be controlled? Under GL was that possible and got it in, because a single pixel at 3840x2160 is barely visible.

Or is it possible by means of <dependency type =" visible "... </ dependency> in settings.xml to check if Windows is present?

Further is the feature related to https://github.com/xbmc/visualization.spectrum/issues/23 added to select a fixed angle. Bildschirmfoto von 2019-03-23 01-03-48

Rechi commented 5 years ago

It doesn't work on OSX, but there is nothing in the log file.

AlwinEsch commented 5 years ago

I bought a used MacMini which come the next days to check this, maybe possible that OSX can not work without "glBufferData".

kekukui commented 5 years ago

The abandonment of OpenGL means that developers wanting to use a single cross-platform graphics API are out of luck. You can still develop against the 4.1 feature set, but nothing newer. https://www.quora.com/Why-is-OpenGL-poorly-supported-on-Mac-OS-X

OpenGL Extensions Viewer for Mac OS https://mac.softpedia.com/get/System-Utilities/OpenGL-Extensions-Viewer.shtml

OpenGL features chart for Mac hardware https://developer.apple.com/opengl/OpenGL-Capabilities-Tables.pdf