xbmc / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS, tvOS and Windows.
https://kodi.tv/
Other
18.23k stars 6.28k forks source link

Matroska Audio Files (.mka): Not all tags read into Music db #16349

Open HomerJau opened 5 years ago

HomerJau commented 5 years ago

Bug report

Describe the bug

Music files using Matroska Audio (.mka) with Matroska Metadata tags do not load ALBUM object tags into the Kodi music library on scanning.

Without album tag information any Matroska music files do not contain albumartist, album name and year data. This library information is important and required.

The problem has been discussed in Kodi music forum and has be identified as an ffmpeg issue by Dave Blake.

This PR is to ensure changes required in Kodi to support new tags from ffmpeg (when its fixed) are in the system.

Expected Behavior

Here is a clear and concise description of what was expected to happen:

Album tags from .mka files will be read and transferred to the Kodi music database just like tags from other music file containers supported by Kodi..

Actual Behavior

Album tags are ignored by ffmpeg (and hence Kodi) for .mka music file containers.

Possible Fix

I have raised a defect bug on ffmpeg bug tracker: https://trac.ffmpeg.org/ticket/7988#

Kodi work required is to ensure ffmpeg data is read by Kodi tag code (once ffmpeg is fixed)

To Reproduce

Steps to reproduce the behavior:

  1. Scan any tagged Matroska mka file into the kodi music library
  2. View the file in Kodi (see missing or incorrect tags: Album name is always 'Singles')

Sample Files: Small mka (Matroska Audio files) sample files tagged with MP3tag: ​https://drive.google.com/drive/folders/18OXbob8IC_A9pNSPRDxmNc_8NSrDwAQ-?usp=sharing

Debuglog

The debuglog can be found here:

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

I've reproduced on

This issue affects all Kodi versions/OSs

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

henkypunky commented 5 years ago

Wondering about this as I recently retrofitted tags to my mka files with foobar2000 and the album titles are extracted as expected. Just double checked with mp3Tag, the tag being used is ALBUM. This is true for Kodi 18.3 on vero4k as well as 18.2 on Fire TV stick 4k.

DaveTBlake commented 5 years ago

@henkypunky are you are saying you have .mka files that Kodi v18 is correctly reading album name from? If so then can you provide an example music file. I suspect that it may have ID3 v2 metadata and not Matroska, but need to see the file.

henkypunky commented 5 years ago

@DaveTBlake Well, I guess I can't for legal reasons. However, maybe you can tell me how to get the info from the file? Which tool to use

github-actions[bot] commented 1 month ago

This issue is now marked stale because it has been open over a year without activity. Remove the stale label or add a comment to reset the stale state.