search

xbmc / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS, tvOS and Windows.
https://kodi.tv/
Other
18.43k stars 6.3k forks source link

Subtitle Size in KODI Alpha widely vary in size and format efffected by video file format. #21718

Closed kleczerx closed 2 years ago

kleczerx commented 2 years ago

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

Expected Behavior

Here is a clear and concise description of what was expected to happen:

The subtitles should conform to the selected setting in Kodi Setup > settings > Player > Subtitles > Size..

Actual Behavior

Rather, the size of the subtitles conform to the video format played at the time. The size of subtitles may vary/change from one video format to another, large or small size.

Possible Fix

Disassociate video format effects on subtitle format.

To Reproduce

Steps to reproduce the behavior:

  1. Play 2160p or 1080p video after setting subtitles size to (e.g) 30.
  2. Play, with subtitles, one format then the other format. If all is well, the subtitles should remain similar; otherwise different sizes.
  3. Playing two similary formats (both 1080p for example) will also differ subtitle size view because rarely do video formats maintain similar standards.

Debuglog

The debuglog can be found here:

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

I suffer viewing generally extrememly large texted subtitles.

Your Environment

Used Operating system:

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

CastagnaIT commented 2 years ago

the situation is not full clear, so is needed:

i tried replicate by using 1080p monitor, by trying to compare 640p movie with a 4k movie but i see always same text size (srt) i tried to replicate by emulating 4k monitor (i dont have 4k monitor) and i dont see differences in text size between 4k movie/srt and 1080p movie/srt so for now i have no idea whats happens to you

OTHER PROBLEM: In most cases, each line of the subtitle text does not recogize double or triple line setting and display the line a a single line displayed from the extreme left to the right edge of the screen; better said, subtitles generally display 2 or 3 lines at a time but now only as a single line.

for this "other problem", you must provide a subtitle file on which to test or share part of your video

we will see after we have all the info

kleczerx commented 2 years ago

From: Kleczek - Toronto Sent: Wednesday, 3 August, 2022 18:01 To: xbmc/xbmc @.***> Subject: RE: [xbmc/xbmc] Subtitle Size in KODI Alpha widely vary in size and format efffected by video file format. (Issue #21718)

Subtitles vary in size.

Overall, the best way to observe subtitles font sizes and positioning changes is to use the keyboard “Z” key to change video format. This key will give a number of video formats, for the one video played at the time, to simulate format changes from one video file to another. Previous Kodi version had the subtitle remain a standard size (standard meaning that chosen in Kodi settings) dispite the video format or the use of the Z key to effect the video format.

Bug Log: I have nothing to show.

My configuration: TV Samsung 900t QLED 8K (my desktop PC Windows 11 with 4K monitor) Media Player: Nvidea Shield | Kodi Alpha2 ARMV8A (64Bit) Windows 11 Kodi Alpha2 (x64)

Tried to send photo samples of subtitles shown based on format. The email was constantly rejected. So no photo samples shown..:

Many thanks for emailing me direct.

Richard Kleczek Toronto, Canada.

====================================================================================

From: Stefano Gottardo @.**@.>> Sent: Monday, 1 August, 2022 04:13 To: xbmc/xbmc @.**@.>> Cc: kleczerx @.**@.>>; Author @.**@.>> Subject: Re: [xbmc/xbmc] Subtitle Size in KODI Alpha widely vary in size and format efffected by video file format. (Issue #21718)

the situation is not full clear, so is needed:

i tried replicate by using 1080p monitor, by trying to compare 640p movie with a 4k movie but i see always same text size i tried to replicate by emulating 4k monitor (i dont have 4k monitor) and i dont see differences in text size between 4k movie/srt and 1080p movie/srt so for now i have no idea whats happens to you

OTHER PROBLEM: In most cases, each line of the subtitle text does not recogize double or triple line setting and display the line a a single line displayed from the extreme left to the right edge of the screen; better said, subtitles generally display 2 or 3 lines at a time but now only as a single line.

for this "other problem", you must provide a subtitle file on which to test

we will see after we have all the info

— Reply to this email directly, view it on GitHubhttps://github.com/xbmc/xbmc/issues/21718#issuecomment-1200867509, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKTE7ITUKX7EOW5S24DBAALVW6BI5ANCNFSM55D7WWGQ. You are receiving this because you authored the thread.Message ID: @.**@.>>

CastagnaIT commented 2 years ago

i have not sent to you an e-mail, what you are receiving are automated GitHub notifications e-mail messages

in order to attach files you have to go to where you opened the Issue by using the browser, i not suggest to reply by using e-mail because add a lot of junk to the messages

"Z" shortcut force change the "view" format and currently affect subtitles this is already know from my part i havent found no valid solution to avoid this influence

bunker2045 commented 2 years ago

I also observe different subtitles size on different videos, although all videos are 4K and I do not switch resolution or any settings.

After doing some tests I noticed that video aspect ratio has an effect on subtitles size. With 2.40:1 videos (3840x1600) subtitles are much smaller that with 1.78:1 videos (3840x2160).

This issue is always reproducible. I use Fire TV Stick 4K running kodinerds build of Kodi. The stick is connected to a 4K TV.

Just for a test I installed Kodi on my old MacBook (nightly build kodi-20220813-61f7ea86-master-26619-x86_64.dmg) and tried the same video files. The subtitles size was the same for all videos!

CastagnaIT commented 2 years ago

Here we do not provide support to custom kodi builds like kodinerd

so please install official kodi builds or we dont spend futher time on this Issue

i have done another test on android with NVIDIA Shield and 4k tv following use cases:

with screen resolution as first set as 4k, and after set to 1080p all videos have SRT subtitles

the results are that subtitles text is rendered with same size with all type of videos and resolutions

again if you have View mode setting (screenshot below), set different than "normal", please set it again to "normal" immagine this setting is know to influence the text size if not, it is more likely a kodinerd bug or something related to not mentioned changed setting which i am not aware of, or advancedsettings

bunker2045 commented 2 years ago

Thank you very much for looking into this.

I did more testing using official Kodi Android build and I was able to reproduce the issue on both my systems: Fire TV 4K Max with Android (official build) and Mac (official build).

The issue occurs only when Position on screen (under Settings/Player/Subtitles) is set to Below video or Above video.

It doesn't happen with the default Bottom of video. That's why I couldn't reproduce this on Mac in my first test.

CastagnaIT commented 2 years ago

oh ok could have sense in my tests i never changed position but atm i cannot test again, this PR #21680 could have already fixed your problem but is in waiting to be merged, i think the best is i will provide you some test builds with this change so you can give a feedback

bunker2045 commented 2 years ago

I'd be happy to test if you could provide me with an Android build. Thank you.

kleczerx commented 2 years ago

Richard K – I have two Shield Nvidea units (using Kodi Android Kodi V20-arm64-v8a ) on an 8K and 4K TV and I always set my subtitles to “below video” so you may found something…. Great!

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: Wednesday, August 17, 2022 11:54 AM To: @.> Cc: @.>; @.> Subject: Re: [xbmc/xbmc] Subtitle Size in KODI Alpha widely vary in size and format efffected by video file format. (Issue #21718)

Thank you very much for looking into this.

I did more testing using official Kofi Android build and I was able to reproduce the issue on both my systems: Fire TV 4K Max with Android (official build) and Mac (official build).

The issue occurs only when Position on screen (under Settings/Player) is set to Below video or Above video.

It doesn't happen with the default Bottom of video. That's why I couldn't reproduce this on Mac in my first test.

— Reply to this email directly, view it on GitHubhttps://github.com/xbmc/xbmc/issues/21718#issuecomment-1218207798, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKTE7IRAZHBVQI2YV2RGT43VZUDLXANCNFSM55D7WWGQ. You are receiving this because you authored the thread.Message ID: @.***>

kleczerx commented 2 years ago

As I said before I have always set my subtitles to “below video”.

My Build information: Screen resolution: 3840x2160 @ 59.94 Hz – Full Screen Operating System: Android TV 11.0.0 API Level 30 (kernel: Linux 4.9.141-tegra…) KODI build: 20.0 ALPHA2 (19.90.705)

I will test the subtitle sizing issue by using the Settings for Kodi and positioning the subtitles to different parts of the screen.

Richard K Toronto, ON

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: Wednesday, August 17, 2022 1:04 PM To: @.> Cc: @.>; @.> Subject: Re: [xbmc/xbmc] Subtitle Size in KODI Alpha widely vary in size and format efffected by video file format. (Issue #21718)

I'd be happy to test if you could provide me with an Android build. Thank you.

— Reply to this email directly, view it on GitHubhttps://github.com/xbmc/xbmc/issues/21718#issuecomment-1218280161, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKTE7IXWHGZLFXKWKGQOIP3VZULSJANCNFSM55D7WWGQ. You are receiving this because you authored the thread.Message ID: @.***>

CastagnaIT commented 2 years ago

These are test builds, choose what you prefeer: Android arm: http://mirrors.kodi.tv/test-builds/android/arm/kodi-20220817-81cffbd5-subtitle_pos-26330-armeabi-v7a.apk Android arm64: http://mirrors.kodi.tv/test-builds/android/arm64-v8a/kodi-20220817-81cffbd5-subtitle_pos-23835-arm64-v8a.apk Window 64bit: http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20220810-81cffbd5-subtitle_pos-x64.exe i cannot provide macos build atm

bunker2045 commented 2 years ago

I've tried the Android v7a build and can confirm the issue is fixed there. Thank you very much!

BTW what is the best way to ask questions or feature requests about subtitles? I would think it's Kodi forum but I'm not sure which sub-forum it should be. There are so many.

CastagnaIT commented 2 years ago

@bunker2045 for questions you can ask in "general support" by choosing the preferred OS: https://forum.kodi.tv/forumdisplay.php?fid=111 for feature requests this section: https://forum.kodi.tv/forumdisplay.php?fid=9

thanks for confirming we will waiting also @kleczerx response

CastagnaIT commented 2 years ago

@kleczerx i see that you still use email notification to read the Issue discussion if you miss, some message above i attached the test builds links, here: https://github.com/xbmc/xbmc/issues/21718#issuecomment-1218307880 so if you can please do a test and report a feedback thanks

CastagnaIT commented 2 years ago

Since there are no more replies for the test build and the fix has been just merged (for video View setting) this will be marked as fixed for the:

OTHER PROBLEM: ...

suggest you if needed to post your problem in the forum or open another issue by providing the subtitle file that raise the problem