search

xbmc / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS, tvOS and Windows.
https://kodi.tv/
Other
18.27k stars 6.28k forks source link

Dolby Vision support #22408

Closed satmandu closed 1 year ago

satmandu commented 1 year ago

With the closure of https://github.com/xbmc/xbmc/pull/18965 in https://github.com/xbmc/xbmc/pull/18965#issuecomment-1373649222 is a new PR is needed to support Dolby Vision / DV mkv files?

(And does there need to be a separate Issue created to ask for tone mapping support for playing Dolby Vision files on Non-HDR displays?)

fandangos commented 1 year ago

https://github.com/xbmc/xbmc/pull/22410/

Let's see how it goes.

But FYI there's no SDR tonemapping for Dolby Vision content ONLY in any device as far as I know. Even the OPPO 203 Bluray Player uses the HDR10 metadata for SDR tonemapping. The same goes for Emby as far as I can test. Files with Dolby Vision layer only do not will not be tonemapped and will display a pink and purple image OR an unsatured image.

satmandu commented 1 year ago

Jellyfin can do tone mapping. There are flags passed to ffmpeg...

fandangos commented 1 year ago

Link to commit?

Also, the same goes for MadVR outstanding tonemapping made frame by frame, but still uses HDR10, unless something has changed.

satmandu commented 1 year ago

It's mentioned in this thread:

https://www.reddit.com/r/jellyfin/comments/uzid62/dolby_vision_tonemapping_support_for_transcodes/iacgt9h/

satmandu commented 1 year ago

More specifically:

https://www.reddit.com/r/jellyfin/comments/v2nudu/dolby_vision_to_sdr_hwa_tonemapping_is_coming

fandangos commented 1 year ago

Well, things do change over time :)

But that tonemap is done server side, not on player side. Also, the Nvidia Shield now has the option to disable Dolby Vision and that forces tonemapping for the player. DV only content doesn't work.

So, as far as I know, only Jellyfin transcoding can do it. It might be possible to bring that to Kodi on Windows/Linux but I don't see how it can be done on Android (way above what I can do too).

satmandu commented 1 year ago

Agreed on tone mapping in android possibly being an issue. But for those of us running kodi standalone on a machine with the GPU capabilities to do so, it should be possible (dare I say ideal?) for kodi to do that as well, since it could also pass ffmpeg the same flags to tone map.

I'll open a separate issue for Dolby Vision tone mapping then...

fuzzard commented 1 year ago

Feature requests on forums as always. This is a bug tracker only