xbmc / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS, tvOS and Windows.
https://kodi.tv/
Other
18.59k stars 6.31k forks source link

[Kodi 21 Beta3] Extract video information from files don't works from "KodiSetup-20240102-751e6c3b" with TV Shows #24498

Closed Nanomani closed 10 months ago

Nanomani commented 10 months ago

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

From Kodi (21.0-BETA2 (20.90.821) Git:20240102-751e6c3b55) when you add a new Tv Show or if you full refresh information for a existing Tv Show in library, all information from file (episode) are empty.

Expected Behavior

Here is a clear and concise description of what was expected to happen:

I expect to see all video information (codec, resolution, aspect...) for each episode.

Actual Behavior

There is only the video duration

Possible Fix

The latest Kodi version without issue is : 21.0-BETA2 (20.90.821) Git:20240101-7413267da7

To Reproduce

Steps to reproduce the behavior:

(All test are made from a clean Kodi install with all default settings)

Scenario 1 : add a new TV Show in library

  1. use Kodi (21.0-BETA2 (20.90.821) Git:20240102-751e6c3b55) or newer
  2. add a new tvshow
  3. then open this tvshow information
  4. list the episode information

Scenario 2 : refresh a TV Show already in library with all video information correctly stored

  1. use Kodi (21.0-BETA2 (20.90.821) Git:20240102-751e6c3b55) or newer
  2. open information for this tvshow
  3. then refresh all information for all episode
  4. list the episode information

Debuglog

The debuglog can be found here:

After scrape a new TV Show https://paste.kodi.tv/ijiwanutow.kodi

After refresh a tvshow already in library with all video information correctly stored https://paste.kodi.tv/raloqocuvu.kodi

Screenshots

Here are some links or screenshots to help explain the problem:

The issue after a full refreh / a new TV Show added :

2024-01-13_132955

2024-01-13_133521

What is expected :

2024-01-13_132009

2024-01-13_135403

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Tested with the latest nightly Kodi version : KodiSetup-20240112-5198ea50-master-x64

The issue is the same

Your Environment

Used Operating system:

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

biner73 commented 10 months ago

I am seeing this same issue. Noticed this behavior started recently, sometime after the Beta 2 build. The Beta 2 build does not have this issue.

Something else to add, I've confirmed this to be occuring with both the MovieDB TV Shows and the TVDB4 scrapers alike.

biner73 commented 10 months ago

@the-black-eagle Having a quick look at the merges after the latest working build 7413267da7, could possibly be related to this change? https://github.com/xbmc/xbmc/pull/24386

the-black-eagle commented 10 months ago

Meh !! So, what's happening is that there are streamdetails for episodes, but only a duration. Therefore, the test for no streamdetails fails and the file is not probed.

What I need to dig into, is whether that duration is not getting reset correctly, or whether it's coming from the scraper.

The symptom is clear, now to find the root cause and establish a fix.

Hitcher commented 10 months ago

@the-black-eagle pretty sure the duration is coming from the scraper as we show the exact duration including seconds whereas tmdb doesn't.

the-black-eagle commented 10 months ago

@Hitcher Yeah, it is. The scraper calls addVideoStream() and adds (just) the duration to it. Therefore HasStreamDetails() returns true, even though it's only a partial detail.

I have a fix which checks for one of the following missing

If just one of those is missing, then the file will be checked for the details. I don't see a need really to check for missing audio stuff as I don't know of any 3rd party nfo manager that would miss out audio info but include video info. As a minimum, I would expect an nfo file to include all of that list, but if not, then the file will be probed anyway.

In my tests, nfo files are read correctly, even if they contain wrong info (as long as it is present). Refreshing from internet now works correctly for movies and tv shows. Music videos aren't affected as the scraper doesn't return any stream details anyway.

Bit more testing to do but PR should be done soon.