search

xbony2 / Nuclear-Control

An updated version of nuclear control.
BSD 3-Clause "New" or "Revised" License
24 stars 36 forks source link

update cape module #183

Closed maggi373 closed 2 years ago

maggi373 commented 3 years ago

an update for the cape module, i dont know if ya want to add this but its there, you will also get an fix for your json so capes will work again

maggi373 commented 3 years ago

several other modpacks had to remove this module because of the outdated module and the json file is bad making other mods capes not work like mine. Turning off capes in the settings page wont fix this problem

xbony2 commented 3 years ago

This mod is discontinued but if it's breaking a lot of things I can try to (merge this and) publish a new version.

xbony2 commented 3 years ago

(see also https://github.com/xbony2/xbony2.github.io/pull/8 )

maggi373 commented 3 years ago

It's not an importnant thing, there are several forked version fixing this. Just that its rather an easy fix and releasing it. I can think of smaller modpack devs not including this mod because of reasons they might have.

maggi373 commented 3 years ago

You can also make another branch and release an cape fix version for those needing it and dont know how to compile themself

maggi373 commented 3 years ago

Its also an security issue by using http and not https, you are open to man in the middle attacks

xbony2 commented 2 years ago

Took a long time but im gonna do it

xbony2 commented 2 years ago

It's gonna take a while to actually release this though since the build is totally broken by migrated resources and so on