search

xbrowsersync / api

Server-side REST API that serves requests from xBrowserSync client apps
GNU General Public License v3.0
796 stars 83 forks source link

dailyNewSyncsLimit or status.allowNewSyncs ? #23

Closed swestlake closed 5 years ago

swestlake commented 5 years ago

it's difficult to track similar options, the config description is also not too clear between these two settings,

dailyNewSyncsLimit --> setting this to 0 "disables all new syncs", or allows "unlimitted syncs" ?

status.allowNewSyncs --> I suppose would be the ultimate decider whether 1 new sync is permissible.

There should be added text to dailyNewSyncsLimit's description to clarify that new syncs become possible as long as status.allowNewSyncs is enabled..

All the other options look well explained.. and because I think there's lots of them, that I think it's a good idea imho to have vice-versa in both places to remind users to check both settings(as each of these two affects the other).

thanks

nero120 commented 5 years ago

Thanks @swestlake, hopefully with that commit the explanation of dailyNewSyncsLimit is clearer. To be fair, I could probably just have one option for max number of daily syncs per user, 0 being none and -1 being unlimited. Will think about that for a future release.