xbrowsersync / api

Server-side REST API that serves requests from xBrowserSync client apps
GNU General Public License v3.0
796 stars 83 forks source link

Stuck sync on v1.1.0 API, Chrome extension v1.3.1 #6

Closed cjnaz closed 6 years ago

cjnaz commented 6 years ago

The sequence I tried (may be helpful):

To solve the hang I tried to disable sync. This resulted in the local Chrome extension reloading my local bookmarks about a dozen times. It eventually stopped and gave a popup saying something like my sync had been restored. The first (incorrect) and separator bookmarks are there and the second bookmark is not. Note that I have two Chrome windows open.

I then try to create a new sync and got a daily new sync limit reached. For "new" syncs, I only tried once.

image

image

image

cjnaz commented 6 years ago

After waiting until the next day, a new sync worked fine. Two possible corner cases

  1. The original sync was against API v1.0.3. Perhaps generating a new sync when changing to v1.1.0 is in order?
  2. I did the follow on changes within the Google bookmarks while the sync from the first change was in progress.
nero120 commented 6 years ago

Hi @cjnaz, I'll try to recreate this locally this week when I have some time. I did a fair bit of testing to ensure that existing syncs worked as normal after upgrading from v1.0.3 to v1.1.0, I suspect it's actually an edge case bug with the App rather than the API.

The sync limit issue you hit was possibly due to a configuration issue with the server that I introduced after I did the upgrade to v1.1.0, this has been resolved now so you can create a maximum of 3 new syncs per day. I also upgraded the server resources as it was struggling after the upgrade. The bonus is it's quicker, more stable and everyone now gets 1MB of data sync allowance!

nero120 commented 6 years ago

Going to close this as nothing more to be done here I don't think...