search

xcarpentier / react-native-country-picker-modal

🇦🇶 Country picker provides a modal allowing a user to select a country from a list. It display a flag next to each country name.
https://reactnative.gallery/xcarpentier/country-picker
MIT License
1.08k stars 802 forks source link

CountryPicker.renderFlag does not use Default Styles when Invoked Outside of Component #131

Closed ryanrossiter closed 5 years ago

ryanrossiter commented 6 years ago

When calling CountryPicker.renderFlag (or renderImageFlag/renderEmojiFlag) from outside of the component, such as in the case of rendering a standalone flag, the default styles are not applied. This seems counter-intuitive since the flags are rendered with default styles within the component if none are provided.

The base styles should be applied by default and then be overridden by styles passed to either the component in the styles prop or in the arguments of the renderFlag function.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.